Skip to content

Adding codestarter to server extension - issue #1021 #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

Adding codestarter to server extension - issue #1021 #1037

merged 1 commit into from
Mar 20, 2025

Conversation

@vladprado
Copy link
Contributor

@vladprado vladprado commented Mar 10, 2025

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

Link to issue #1021

There's no codestart in the server extension of the project.
Used the client extension as baseline for this implementarion.

@vladprado vladprado requested a review from a team as a code owner March 10, 2025 04:24
@hbelmiro hbelmiro linked an issue Mar 10, 2025 that may be closed by this pull request
Add codestarter to server extension #1021
Closed
@ricardozanini ricardozanini added the area:server This item is related to the server extension label Mar 10, 2025
@mcruzdev
Copy link
Member

mcruzdev commented Mar 11, 2025

Hi @vladprado nice pull request, I am reviewing it now, could you add test?

mcruzdev
mcruzdev reviewed Mar 11, 2025
View reviewed changes
mcruzdev
mcruzdev reviewed Mar 11, 2025
View reviewed changes
mcruzdev
mcruzdev reviewed Mar 11, 2025
View reviewed changes
mcruzdev
mcruzdev reviewed Mar 11, 2025
View reviewed changes
@vladprado
Copy link
Contributor Author

vladprado commented Mar 11, 2025

Hi @vladprado nice pull request, I am reviewing it now, could you add test?

@mcruzdev , I was looking at the code start docs and got confused where I would create this test for the extension.
Should I create a separata package for it or include one package in each of the modules (reactive, resteasy)?

@mcruzdev
Copy link
Member

mcruzdev commented Mar 11, 2025

Hi @vladprado, sorry for delay, I think you can create a new one.

@mcruzdev
Copy link
Member

mcruzdev commented Mar 14, 2025

Hi @vladprado, as we talked previously, I adjusted the codestart, but we have some changes (I added new comments).

@mcruzdev
Copy link
Member

mcruzdev commented Mar 14, 2025 •
edited
Loading

The pipeline is failing because the extension is not being installed (mvn install). The codestarts test try to find the dependency locally ;/

cc: @ricardozanini @hbelmiro I think we need to add mvn install on build workflow, WDYT?

@vladprado vladprado force-pushed the feat/server-codestart branch from 5641a9b to a04ed31 Compare March 14, 2025 15:34
@vladprado
Add codestarts to server extension - issue quarkiverse#1021
4171bf9 
Add codestart to server extension - issue quarkiverse#1021

Adding codestarter to server extension - issue quarkiverse#1021

minor fixes and tests requested in PR

Test update and final touches to codestart server extension

Codestart test adjustments

Adjust codestarts

Add deps version

Use install instead

Add codestart for the server extension - issue quarkiverse#1021

Adding codestarts to server extension - issue quarkiverse#1021

Adding codestarts to server extension - issue quarkiverse#1021
@vladprado vladprado force-pushed the feat/server-codestart branch from a04ed31 to 4171bf9 Compare March 15, 2025 02:29
mcruzdev
mcruzdev approved these changes Mar 15, 2025
View reviewed changes
Copy link
Member

@mcruzdev mcruzdev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice pull request @vladprado, good job!

@mcruzdev
Copy link
Member

mcruzdev commented Mar 18, 2025

@hbelmiro @ricardozanini could you take a look?

@hbelmiro hbelmiro merged commit bbe84e7 into quarkiverse:main Mar 20, 2025
7 checks passed
@hbelmiro
Copy link
Contributor

hbelmiro commented Mar 20, 2025

@all-contributors add @vladprado for code docs tests.

@allcontributors
Copy link
Contributor

allcontributors bot commented Mar 20, 2025

@hbelmiro

@vladprado already contributed before to code, doc, test

@hbelmiro
Copy link
Contributor

hbelmiro commented Mar 20, 2025

@all-contributors add @vladprado for code

@allcontributors
Copy link
Contributor

allcontributors bot commented Mar 20, 2025

@hbelmiro

@vladprado already contributed before to code

@hbelmiro
Copy link
Contributor

hbelmiro commented Mar 20, 2025

@ricardozanini there's something wrong with the all-contributors bot. @vladprado has never contributed to this repo before.

@mcruzdev
Copy link
Member

mcruzdev commented Mar 21, 2025

Hi @gastaldi the quarkus-openapi-generator-server is not listed on code.quarkus.io, there is something we need to do?

@gastaldi gastaldi mentioned this pull request Mar 21, 2025
Merged
@gastaldi
Copy link
Member

gastaldi commented Mar 21, 2025

@mcruzdev yes, this is missing: quarkusio/quarkus-extension-catalog#149

@mcruzdev
Copy link
Member

mcruzdev commented Mar 21, 2025

Thank you a lot GOAT!

@vladprado vladprado deleted the feat/server-codestart branch March 21, 2025 14:20
mcruzdev pushed a commit to mcruzdev/quarkus-openapi-generator that referenced this pull request Jul 8, 2025
@vladprado @mcruzdev
Add codestarts to server extension (quarkiverse#1037)
695f72d 
Add codestart to server extension - issue quarkiverse#1021

Adding codestarter to server extension - issue quarkiverse#1021

minor fixes and tests requested in PR

Test update and final touches to codestart server extension

Codestart test adjustments

Adjust codestarts

Add deps version

Use install instead

Add codestart for the server extension - issue quarkiverse#1021

Adding codestarts to server extension - issue quarkiverse#1021

Adding codestarts to server extension - issue quarkiverse#1021
hbelmiro pushed a commit that referenced this pull request Jul 17, 2025
@mcruzdev
Add codestarts to server extension (#1037) (#1232)
019972b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@mcruzdev mcruzdev mcruzdev approved these changes

@hbelmiro hbelmiro Awaiting requested review from hbelmiro

@carlesarnal carlesarnal Awaiting requested review from carlesarnal

Assignees

No one assigned

Labels

area:server This item is related to the server extension backport-main-lts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add codestarter to server extension

5 participants

@vladprado @mcruzdev @hbelmiro @gastaldi @ricardozanini