Skip to content

Fix #1045 - Refactor inputExtension method to inputExtensions #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

Fix #1045 - Refactor inputExtension method to inputExtensions #1052

merged 1 commit into from
Mar 20, 2025

Conversation

@vladprado
Copy link
Contributor

@vladprado vladprado commented Mar 18, 2025 •
edited
Loading

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
Refactor of inputExtension method to inputExtensions The inputExtensions method was deprecated in quarkus 3.7.0 in favor of the inputExtensions method. This issues deals with refactoring the code to use the newer method.

backport-main-lts

#1045

@vladprado vladprado requested a review from a team as a code owner March 18, 2025 02:54
@hbelmiro hbelmiro linked an issue Mar 18, 2025 that may be closed by this pull request
Refactor inputExtension method in io.quarkiverse.openapi.generator.deployment.codegen package to inputExtenions #1045
Closed
@hbelmiro hbelmiro requested a review from ricardozanini March 18, 2025 12:35
ricardozanini
ricardozanini requested changes Mar 19, 2025
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, can you try having only the file OpenApiGeneratorCodeGen class and return an array of extensions? This way we don't need to have 3 classes with 3 different extensions.

@vladprado
Copy link
Contributor Author

vladprado commented Mar 19, 2025

Instead, can you try having only the file OpenApiGeneratorCodeGen class and return an array of extensions? This way we don't need to have 3 classes with 3 different extensions.

Sure, @ricardozanini
I will expand the refactoring so it's only one condegen class.

@vladprado vladprado force-pushed the fix/inputExtensions branch from ff3ae24 to f51f419 Compare March 20, 2025 15:11
@vladprado
Copy link
Contributor Author

vladprado commented Mar 20, 2025

@ricardozanini , changes made.

ricardozanini
ricardozanini reviewed Mar 20, 2025
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minors. We can use open-api instead. Many thanks again for this work!

@vladprado @vladpradoBB
quarkiverse#1045 - Refactor inputExtension method to inputExtensions
61690f3 
 quarkiverse#1045 - Refactor inputExtension method to inputExtensions# This is a combination of 2 commits.

 quarkiverse#1045 - Refactor inputExtension method to inputExtensions
@vladprado vladprado force-pushed the fix/inputExtensions branch from f51f419 to 61690f3 Compare March 20, 2025 20:41
@vladprado
Copy link
Contributor Author

vladprado commented Mar 20, 2025

@ricardozanini , updated the path for the files.
If you need anything, let me know.

ricardozanini
ricardozanini approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Many thanks!

@ricardozanini ricardozanini merged commit 0b85735 into quarkiverse:main Mar 20, 2025
7 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 20, 2025
@vladprado
#1045 - Refactor inputExtension method to inputExtensions (#1052)
cd499f3 
#1045 - Refactor inputExtension method to inputExtensions# This is a combination of 2 commits.

 #1045 - Refactor inputExtension method to inputExtensions
@github-actions github-actions bot mentioned this pull request Mar 20, 2025
Merged
7 tasks
hbelmiro pushed a commit that referenced this pull request Mar 21, 2025
@github-actions @vladprado
#1045 - Refactor inputExtension method to inputExtensions (#1052) (#…
290a83a 
…1061)

#1045 - Refactor inputExtension method to inputExtensions# This is a combination of 2 commits.

 #1045 - Refactor inputExtension method to inputExtensions

Co-authored-by: vladprado <[email protected]>
@hbelmiro
Copy link
Contributor

hbelmiro commented Mar 23, 2025

@all-contributors add @vladprado for code, tests and doc.

@allcontributors
Copy link
Contributor

allcontributors bot commented Mar 23, 2025

@hbelmiro

@vladprado already contributed before to code, test, doc

@vladprado vladprado deleted the fix/inputExtensions branch April 1, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@hbelmiro hbelmiro hbelmiro approved these changes

@mcruzdev mcruzdev mcruzdev approved these changes

Assignees

No one assigned

Labels

backport-main-lts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor inputExtension method in io.quarkiverse.openapi.generator.deployment.codegen package to inputExtenions

4 participants

@vladprado @hbelmiro @ricardozanini @mcruzdev