Skip to content

Conversation

@jghagemann
Copy link
Contributor

@jghagemann jghagemann commented Mar 21, 2025

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@jghagemann jghagemann requested a review from a team as a code owner March 21, 2025 02:34
@mcruzdev mcruzdev linked an issue Mar 21, 2025 that may be closed by this pull request
Copy link
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jghagemann thanks a lot, this pull request looks really good, I left some comments for discussion :)

@jghagemann jghagemann requested a review from mcruzdev March 21, 2025 13:48
@jghagemann jghagemann requested a review from mcruzdev March 21, 2025 14:42
Copy link
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jghagemann, thanks a lot!

Could you squash the commits?

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contributions! I just add a few suggestions to improve clarity.

@ricardozanini ricardozanini added the area:documentation Improvements or additions to documentation label Mar 21, 2025
@hbelmiro hbelmiro merged commit 04a46b6 into quarkiverse:main Mar 23, 2025
11 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 23, 2025
hbelmiro pushed a commit that referenced this pull request Mar 23, 2025
Co-authored-by: João Guilherme Hagemann <[email protected]>
@hbelmiro
Copy link
Contributor

@all-contributors add @jghagemann for doc.

@allcontributors
Copy link
Contributor

@hbelmiro

I've put up a pull request to add @jghagemann! 🎉

@jghagemann jghagemann deleted the issue-1048 branch March 23, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:documentation Improvements or additions to documentation backport-main-lts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create an issue template

4 participants