Add support for basic auth propagation #1078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-farache
force-pushed
the
feat/basic_auth_propagation
branch
3 times, most recently
from
60cba7b to
e5b6cf1
Compare
ricardozanini
approved these changes
Mar 28, 2025
ricardozanini
requested review from
fjtirado,
hbelmiro,
mcruzdev and
rmanibus
and removed request for
rmanibus
Member
fjtirado
approved these changes
Apr 3, 2025
Contributor
fjtirado
left a comment
fjtirado
left a comment
There was a problem hiding this comment.
Two picky suggestions
I know you head ternary operator, but it simplifies assignment in this case
...me/src/main/java/io/quarkiverse/openapi/generator/providers/BasicAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...e/src/test/java/io/quarkiverse/openapi/generator/providers/BasicOpenApiSpecProviderTest.java
Outdated
Show resolved
Hide resolved
gabriel-farache
force-pushed
the
feat/basic_auth_propagation
branch
3 times, most recently
from
3f64916 to
798c2fb
Compare
Signed-off-by: gabriel-farache <[email protected]>
Signed-off-by: gabriel-farache <[email protected]>
gabriel-farache
force-pushed
the
feat/basic_auth_propagation
branch
2 times, most recently
from
f1921c3 to
6fb7dc3
Compare
Co-authored-by: Francisco Javier Tirado Sarti <[email protected]>
gabriel-farache
force-pushed
the
feat/basic_auth_propagation
branch
from
6fb7dc3 to
eb973e0
Compare
Contributor
Author
|
@ricardozanini Do you think we can merge it? |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
* Fix propagation test for bearer provider Signed-off-by: gabriel-farache <[email protected]> * Add suport for basic auth token propagation Signed-off-by: gabriel-farache <[email protected]> * Refactor based on feedback and update tests acordingly Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> --------- Signed-off-by: gabriel-farache <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
7 tasks
hbelmiro
pushed a commit
that referenced
this pull request
Apr 14, 2025
* Fix propagation test for bearer provider * Add suport for basic auth token propagation * Refactor based on feedback and update tests acordingly --------- Signed-off-by: gabriel-farache <[email protected]> Co-authored-by: gabriel-farache <[email protected]> Co-authored-by: Francisco Javier Tirado Sarti <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectThis PR solves #1075 and aims at adding suport for basic auth token propagation