Support GAV coordinates for client generation #1340 #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ricardozanini have a look at it. of couse i will add docu for it if its is ok in your opinion. |
.../quarkiverse/openapi/generator/deployment/codegen/GAVCoordinateOpenApiSpecInputProvider.java
Outdated
Show resolved
Hide resolved
.../quarkiverse/openapi/generator/deployment/codegen/GAVCoordinateOpenApiSpecInputProvider.java
Outdated
Show resolved
Hide resolved
...se/openapi/generator/deployment/codegen/YamlOrJsonGAVCoordinateOpenApiSpecInputProvider.java
Show resolved
Hide resolved
Member
|
Can you also please take a look on the CI? |
added 4 commits
October 24, 2025 10:40
…& tests simplicity & add config options to GlobalCodegenConfig
…spec mapping to ensure that config key is right
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ricardozanini
approved these changes
Oct 27, 2025
Member
Contributor
Author
thank you 😃 should i raise another feature req. for addjng the JarGavCoordinateReader? i dont want to add it to this one. maybe i have some time in the next weeks... |
Member
Please do! You can open an issue and implement it once you have the time ;) |
Contributor
Author
|
@ricardozanini when do you plan releasing it? |
Member
Once we have a meaningful pack of PRs merged. I think we can release one patch version this week. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
* Support GAV coordinates for client generation #1340 * Support GAV coordinates for client generation #1340 * avoid star imports * SUPPORTED_EXTENSIONS refactored for better use * add filter for artifactIds & improved config naming(singular/plural) & tests simplicity & add config options to GlobalCodegenConfig * windows problem with colon in filename & extended test with specific spec mapping to ensure that config key is right * use verify phase to store artifacts to local mvn repo to get website / codeql action green * renaming and javadoc * use package phase for artifact installation to get codeql action running --------- Co-authored-by: Michael Sonnleitner <[email protected]>
7 tasks
ricardozanini
added a commit
that referenced
this pull request
Nov 4, 2025
* Support GAV coordinates for client generation #1340 (#1343) * Support GAV coordinates for client generation #1340 * Support GAV coordinates for client generation #1340 * avoid star imports * SUPPORTED_EXTENSIONS refactored for better use * add filter for artifactIds & improved config naming(singular/plural) & tests simplicity & add config options to GlobalCodegenConfig * windows problem with colon in filename & extended test with specific spec mapping to ensure that config key is right * use verify phase to store artifacts to local mvn repo to get website / codeql action green * renaming and javadoc * use package phase for artifact installation to get codeql action running --------- Co-authored-by: Michael Sonnleitner <[email protected]> * Apply suggestion from @ricardozanini * Apply suggestion from @ricardozanini --------- Co-authored-by: Michael Sonnleitner <[email protected]> Co-authored-by: Michael Sonnleitner <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds feature #1340
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectHow to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2to backport the original PR to thequarkus2branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.