Skip to content

Conversation

@ricardozanini
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

Closes #933

In this PR, we added a new custom Qute template function to filter OAuth methods by name since only one CompositeAuthenticationProvider class is required to process OIDC authentication per OAuth instance.

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@ricardozanini ricardozanini requested a review from a team as a code owner January 17, 2025 18:22
Copy link
Contributor

@fjtirado fjtirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks

@ricardozanini
Copy link
Member Author

@fjtirado I made the resolve method a bit more complex so we can use isAssignable and avoid using ArrayList. But the real benefit is to remove the additional condition check in the template.

Signed-off-by: Ricardo Zanini <[email protected]>
@ricardozanini ricardozanini merged commit c311e94 into quarkiverse:main Jan 20, 2025
7 checks passed
@ricardozanini ricardozanini deleted the issue-933 branch January 20, 2025 17:25
github-actions bot pushed a commit that referenced this pull request Jan 20, 2025
…g `CompositeAuthenticationProvider` (#942)

* Fix #933 - Filter oauth security definitions from spec when generating

Signed-off-by: Ricardo Zanini <[email protected]>

* Make 'resolve' more complex by searching for assignable parameters

Signed-off-by: Ricardo Zanini <[email protected]>

* Incorporating @hbelmiro's review

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>
hbelmiro pushed a commit that referenced this pull request Jan 20, 2025
…g `CompositeAuthenticationProvider` (#942) (#950)

* Fix #933 - Filter oauth security definitions from spec when generating



* Make 'resolve' more complex by searching for assignable parameters



* Incorporating @hbelmiro's review



---------

Signed-off-by: Ricardo Zanini <[email protected]>
Co-authored-by: Ricardo Zanini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spec file with multiple flows in the oauth schema leads into duplicated @OauthAuthenticationMarker in CompositeAuthenticationProvider

3 participants