Skip to content

Commit 0c2b365

Browse files
authored
fix: missing closing quote in render, tweak ui (#564)
1 parent 04e8a65 commit 0c2b365

File tree

1 file changed

+36
-25
lines changed

1 file changed

+36
-25
lines changed

core/deployment/src/main/resources/dev-ui/qwc-qosdk-controllers.js

Lines changed: 36 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -36,39 +36,50 @@ export class QWCQOSDKControllers extends QwcHotReloadElement {
3636
render() {
3737
if (this._controllers) {
3838
return html`
39-
<vaadin-vertical-layout>
40-
<qui-badge level="contrast">${this._controllers.length} configured controllers</qui-badge>
41-
<vaadin-vertical-layout style="align-items: stretch; theme="spacing-s padding-s">
39+
<vaadin-details opened>
40+
<vaadin-details-summary slot="summary">
41+
<qui-badge level="contrast">Configured controllers (${this._controllers.length})</qui-badge>
42+
</vaadin-details-summary>
43+
<vaadin-vertical-layout style="align-items: stretch;" theme="spacing-s padding-s">
4244
${this._controllers.map(this.controller, this)}
4345
</vaadin-vertical-layout>
44-
</vaadin-vertical-layout>
46+
</vaadin-details>
4547
`
4648
}
4749
}
4850

4951
controller(controller) {
5052
return html`
51-
<vaadin-details theme="filled">
52-
<vaadin-details-summary slot="summary">
53-
${nameImplAndResource(controller.name, controller.className, controller.resourceClass)}
54-
</vaadin-details-summary>
55-
<vaadin-vertical-layout theme="spacing-s">
56-
<vaadin-details summary="Namespaces" theme="filled">
57-
<vaadin-vertical-layout>
58-
<span>Configured:</span>
59-
${controller.configuredNamespaces.map(ns => html`${name(ns)}`)}
60-
<span>Effective:</span>
61-
${controller.effectiveNamespaces.map(ns => html`${name(ns)}`)}
62-
</vaadin-vertical-layout>
63-
</vaadin-details>
64-
<vaadin-horizontal-layout theme="spacing-s">
65-
${this.children(controller.dependents, "Dependents",
66-
this.dependent)}
67-
${this.children(controller.eventSources, "Event Sources",
68-
this.eventSource)}
69-
</vaadin-horizontal-layout>
70-
</vaadin-vertical-layout>
71-
</vaadin-details>`
53+
<vaadin-details theme="filled">
54+
<vaadin-details-summary slot="summary">
55+
${nameImplAndResource(controller.name, controller.className,
56+
controller.resourceClass)}
57+
</vaadin-details-summary>
58+
<vaadin-vertical-layout theme="spacing-s">
59+
${this.namespaces(controller)}
60+
<vaadin-horizontal-layout theme="spacing-s">
61+
${this.children(controller.dependents, "Dependents",
62+
this.dependent)}
63+
${this.children(controller.eventSources, "Event Sources",
64+
this.eventSource)}
65+
</vaadin-horizontal-layout>
66+
</vaadin-vertical-layout>
67+
</vaadin-details>`
68+
}
69+
70+
namespaces(controller) {
71+
return html`<vaadin-details summary="Namespaces" theme="filled">
72+
<vaadin-vertical-layout>
73+
<vaadin-horizontal-layout theme="spacing-xs">
74+
<span>Configured:</span>
75+
${controller.configuredNamespaces.map(ns => html`${name(ns)}`)}
76+
</vaadin-horizontal-layout>
77+
<vaadin-horizontal-layout theme="spacing-xs">
78+
<span>Effective:</span>
79+
${controller.effectiveNamespaces.map(ns => html`${name(ns)}`)}
80+
</vaadin-horizontal-layout>
81+
</vaadin-vertical-layout>
82+
</vaadin-details>`
7283
}
7384

7485
eventSource(eventSource) {

0 commit comments

Comments
 (0)