fix: start operator by default all the time now (#789)

Author: metacosm

core/deployment/src/main/java/io/quarkiverse/operatorsdk/deployment/OperatorSDKProcessor.java

@@ -124,15 +124,13 @@ void updateControllerConfigurations(
             BuildProducer<SyntheticBeanBuildItem> syntheticBeanBuildItemBuildProducer,
             GeneratedCRDInfoBuildItem generatedCRDs,
             ControllerConfigurationsBuildItem serviceBuildItem,
-            VersionBuildItem versionBuildItem,
-            LaunchModeBuildItem launchMode) {
+            VersionBuildItem versionBuildItem) {
         final var supplier = recorder.configurationServiceSupplier(
                 versionBuildItem.getVersion(),
                 serviceBuildItem.getControllerConfigs(),
                 generatedCRDs.getCRDGenerationInfo(),
                 runTimeConfiguration,
-                buildTimeConfiguration,
-                launchMode.getLaunchMode());
+                buildTimeConfiguration);
         syntheticBeanBuildItemBuildProducer.produce(
                 SyntheticBeanBuildItem.configure(QuarkusConfigurationService.class)
                         .scope(Singleton.class)

core/runtime/src/main/java/io/quarkiverse/operatorsdk/runtime/BuildTimeOperatorConfiguration.java

@@ -42,8 +42,8 @@ public class BuildTimeOperatorConfiguration {
      * Whether the operator should be automatically started or not. Mostly useful for testing
      * scenarios.
      */
-    @ConfigItem
-    public Optional<Boolean> startOperator;
+    @ConfigItem(defaultValue = "true")
+    public Boolean startOperator;
 
     /**
      * Whether the injected Kubernetes client should be stopped when the operator is stopped.

core/runtime/src/main/java/io/quarkiverse/operatorsdk/runtime/ConfigurationServiceRecorder.java

@@ -17,7 +17,6 @@
 import io.javaoperatorsdk.operator.api.config.LeaderElectionConfiguration;
 import io.javaoperatorsdk.operator.api.monitoring.Metrics;
 import io.quarkus.arc.Arc;
-import io.quarkus.runtime.LaunchMode;
 import io.quarkus.runtime.annotations.Recorder;
 import io.quarkus.runtime.configuration.ConfigUtils;
 
@@ -30,7 +29,7 @@ public class ConfigurationServiceRecorder {
     public Supplier<QuarkusConfigurationService> configurationServiceSupplier(Version version,
             Map<String, QuarkusControllerConfiguration> configurations,
             CRDGenerationInfo crdInfo, RunTimeOperatorConfiguration runTimeConfiguration,
-            BuildTimeOperatorConfiguration buildTimeConfiguration, LaunchMode launchMode) {
+            BuildTimeOperatorConfiguration buildTimeConfiguration) {
         final var maxThreads = runTimeConfiguration.concurrentReconciliationThreads
                 .orElse(ConfigurationService.DEFAULT_RECONCILIATION_THREADS_NUMBER);
         final var timeout = runTimeConfiguration.terminationTimeoutSeconds
@@ -89,7 +88,7 @@ public Supplier<QuarkusConfigurationService> configurationServiceSupplier(Versio
                     timeout,
                     cacheSyncTimeout,
                     container.instance(Metrics.class).get(),
-                    shouldStartOperator(buildTimeConfiguration.startOperator, launchMode),
+                    buildTimeConfiguration.startOperator,
                     leaderElectionConfiguration,
                     container.instance(InformerStoppedHandler.class).orElse(null),
                     buildTimeConfiguration.closeClientOnStop,
@@ -116,12 +115,4 @@ private static void setNamespacesFromRuntime(QuarkusControllerConfiguration cont
             controllerConfig.setNamespaces(DEFAULT_NAMESPACES_SET);
         }
     }
-
-    static boolean shouldStartOperator(Optional<Boolean> fromConfiguration, LaunchMode launchMode) {
-        if (fromConfiguration == null || fromConfiguration.isEmpty()) {
-            return LaunchMode.TEST != launchMode;
-        } else {
-            return fromConfiguration.orElse(true);
-        }
-    }
 }

core/runtime/src/test/java/io/quarkiverse/operatorsdk/runtime/ConfigurationServiceRecorderTest.java

@@ -194,7 +194,7 @@ ifndef::add-copy-button-to-env-var[]
 Environment variable: `+++QUARKUS_OPERATOR_SDK_START_OPERATOR+++`
 endif::add-copy-button-to-env-var[]
 --|boolean 
-|
+|`true`
 
 
 a|icon:lock[title=Fixed at build time] [[quarkus-operator-sdk_quarkus.operator-sdk.close-client-on-stop]]`link:#quarkus-operator-sdk_quarkus.operator-sdk.close-client-on-stop[quarkus.operator-sdk.close-client-on-stop]`