Skip to content

Commit dfc8ec4

Browse files
committed
fix db query that was fetching twice the same item
1 parent 1193f5b commit dfc8ec4

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/bindiff/file.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -168,9 +168,11 @@ def _load_file(self, cursor: sqlite3.Cursor) -> None:
168168
169169
:param cursor: sqlite3 cursor to the DB
170170
"""
171-
query = "SELECT * FROM file"
172-
self.primary_file = File(*cursor.execute(query).fetchone())
173-
self.secondary_file = File(*cursor.execute(query).fetchone())
171+
files = cursor.execute("SELECT * FROM file").fetchall()
172+
assert len(files) >= 2
173+
174+
self.primary_file = File(*files[0])
175+
self.secondary_file = File(*files[1])
174176

175177
def _load_metadata(self, cursor: sqlite3.Cursor) -> None:
176178
"""

0 commit comments

Comments
 (0)