Skip to content

Commit 02927cf

Browse files
committed
Replaced "Sponsor[s]" with "Maintained by" and make title casing consistent
1 parent 7a3e227 commit 02927cf

File tree

5 files changed

+18
-19
lines changed

5 files changed

+18
-19
lines changed

src/components/extension-card.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,13 +135,13 @@ const ExtensionCard = ({ extension }) => {
135135
</ExtensionInfo>
136136
<ExtensionInfo>
137137
{extension.metadata.maven?.version
138-
? `Latest Version: ${extension.metadata.maven.version}`
138+
? `Latest version: ${extension.metadata.maven.version}`
139139
: spacer}
140140
</ExtensionInfo>
141141
<ExtensionInfo>
142142
{extension.metadata.maven?.timestamp &&
143143
isValid(+extension.metadata.maven?.timestamp)
144-
? `Last Released: ${format(
144+
? `Last released: ${format(
145145
new Date(+extension.metadata.maven.timestamp),
146146
"MMM dd, yyyy"
147147
)}`

src/components/extension-card.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ describe("extension card", () => {
3939
})
4040

4141
it("renders the version", () => {
42-
expect(screen.getByText("Latest Version: " + version)).toBeTruthy()
42+
expect(screen.getByText("Latest version: " + version)).toBeTruthy()
4343
})
4444

45-
it("renders the Last Released", () => {
46-
expect(screen.getByText("Last Released: Oct 25, 2022")).toBeTruthy()
45+
it("renders the Last released", () => {
46+
expect(screen.getByText("Last released: Oct 25, 2022")).toBeTruthy()
4747
})
4848

4949
it("renders a placeholder image with appropriate source", async () => {

src/templates/extension-detail.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -402,13 +402,13 @@ const ExtensionDetailTemplate = ({
402402

403403
<ExtensionMetadata
404404
data={{
405-
name: "Latest Version",
405+
name: "Latest version",
406406
text: metadata.maven?.version,
407407
}}
408408
/>
409409
<ExtensionMetadata
410410
data={{
411-
name: "Last Released",
411+
name: "Last released",
412412
// Count dates of 0 as undefined, so we don't render them
413413
text: metadata.maven?.timestamp > 0 ? metadata.maven?.timestamp : undefined,
414414
transformer: timestamp =>
@@ -520,8 +520,7 @@ const ExtensionDetailTemplate = ({
520520
/>
521521
<ExtensionMetadata
522522
data={{
523-
name: "Sponsor",
524-
plural: "Sponsors",
523+
name: "Maintained by",
525524
text: sponsors,
526525
}}
527526
/>

src/templates/extension-detail.test.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ describe("extension detail page", () => {
149149
})
150150

151151
it("renders the release date", () => {
152-
const publishDate = "Last Released"
152+
const publishDate = "Last released"
153153
expect(screen.getByText(publishDate)).toBeTruthy()
154154
const dateSection = screen.getByText(publishDate).closest("section")
155155

@@ -226,7 +226,7 @@ describe("extension detail page", () => {
226226
})
227227

228228
it("renders a sponsor field", () => {
229-
expect(screen.getByText("Sponsor")).toBeTruthy()
229+
expect(screen.getByText("Maintained by")).toBeTruthy()
230230
expect(screen.getByText("Automatically Calculated Sponsor")).toBeTruthy()
231231
})
232232

@@ -379,7 +379,7 @@ describe("extension detail page", () => {
379379
})
380380

381381
it("renders a sponsor field, using the information manually set", () => {
382-
expect(screen.getByText("Sponsor")).toBeTruthy()
382+
expect(screen.getByText("Maintained by")).toBeTruthy()
383383
expect(screen.getByText("Manual Sponsor Override")).toBeTruthy()
384384
expect(screen.queryByText("Automatically Calculated Sponsor")).toBeFalsy()
385385
})
@@ -423,7 +423,7 @@ describe("extension detail page", () => {
423423
})
424424

425425
it("renders a sponsor field, using the information manually set", () => {
426-
expect(screen.getByText("Sponsor")).toBeTruthy()
426+
expect(screen.getByText("Maintained by")).toBeTruthy()
427427
expect(screen.queryByText("Automatically Calculated Sponsor")).toBeFalsy()
428428
expect(screen.getByText("Manual Sponsor Override")).toBeTruthy()
429429
})
@@ -468,7 +468,7 @@ describe("extension detail page", () => {
468468
})
469469

470470
it("renders a sponsor field, using the information manually set", () => {
471-
expect(screen.getByText("Sponsor")).toBeTruthy()
471+
expect(screen.getByText("Maintained by")).toBeTruthy()
472472
expect(screen.getByText("Manual Sponsor Override")).toBeTruthy()
473473
expect(screen.queryByText("Automatically Calculated Sponsor")).toBeFalsy()
474474
})
@@ -598,13 +598,13 @@ describe("extension detail page", () => {
598598
link = await screen.queryByText("Version")
599599
expect(link).toBeNull()
600600

601-
link = await screen.queryByText("Latest Version")
601+
link = await screen.queryByText("Latest version")
602602
expect(link).toBeNull()
603603

604604
link = await screen.queryByText("Issues")
605605
expect(link).toBeNull()
606606

607-
link = await screen.queryByText("Sponsor")
607+
link = await screen.queryByText("Maintained by")
608608
expect(link).toBeNull()
609609
})
610610

@@ -666,7 +666,7 @@ describe("extension detail page", () => {
666666
})
667667

668668
it("does not render a release date", () => {
669-
const publishDate = "Last Released"
669+
const publishDate = "Last released"
670670
expect(screen.queryByText(publishDate)).toBeFalsy()
671671
})
672672
})

test-integration/detail-page.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ describe("an extension details page", () => {
3737

3838
it("should have a publish date", async () => {
3939
await expect(
40-
page.waitForSelector(`xpath///*[text()="Last Released"]`)
40+
page.waitForSelector(`xpath///*[text()="Last released"]`)
4141
).resolves.toBeTruthy()
4242
})
4343

@@ -70,7 +70,7 @@ describe("an extension details page", () => {
7070

7171
it("should show a sponsor", async () => {
7272
await expect(
73-
page.waitForSelector(`xpath///*[text()="Sponsor"]`)
73+
page.waitForSelector(`xpath///*[text()="Maintained by"]`)
7474
).resolves.toBeTruthy()
7575
})
7676

0 commit comments

Comments
 (0)