Skip to content

Commit 746c5ba

Browse files
authored
Merge pull request #1408 from sberyozkin/fix_oidc_tenancy_test
Fix the OIDC tenancy test
2 parents 137097f + 9ecd83d commit 746c5ba

File tree

5 files changed

+11
-6
lines changed

5 files changed

+11
-6
lines changed

security-openid-connect-multi-tenancy-quickstart/src/main/java/org/acme/quickstart/oidc/CustomTenantResolver.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import io.quarkus.oidc.OidcTenantConfig;
99
import io.quarkus.oidc.OidcTenantConfig.ApplicationType;
1010
import io.quarkus.oidc.TenantConfigResolver;
11+
import io.quarkus.oidc.runtime.OidcUtils;
1112
import io.smallrye.mutiny.Uni;
1213
import io.vertx.ext.web.RoutingContext;
1314

@@ -17,7 +18,7 @@ public class CustomTenantResolver implements TenantConfigResolver {
1718
@Override
1819
public Uni<OidcTenantConfig> resolve(RoutingContext context, OidcRequestContext<OidcTenantConfig> requestContext) {
1920
String path = context.request().path();
20-
21+
2122
if (path.startsWith("/tenant-a")) {
2223

2324
String keycloakUrl = ConfigProvider.getConfig().getValue("keycloak.url", String.class);
@@ -30,7 +31,7 @@ public Uni<OidcTenantConfig> resolve(RoutingContext context, OidcRequestContext<
3031
config.setApplicationType(ApplicationType.HYBRID);
3132
return Uni.createFrom().item(config);
3233
} else {
33-
// resolve to default tenant config
34+
context.put(OidcUtils.TENANT_ID_ATTRIBUTE, OidcUtils.DEFAULT_TENANT_ID);
3435
return Uni.createFrom().nullItem();
3536
}
3637
}

security-openid-connect-multi-tenancy-quickstart/src/main/resources/application.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Default Tenant Configuration
22
%prod.keycloak.url=http://localhost:8180
3-
%prodquarkus.oidc.auth-server-url=${keycloak.url}/realms/quarkus
3+
%prod.quarkus.oidc.auth-server-url=${keycloak.url}/realms/quarkus
44
quarkus.oidc.client-id=multi-tenant-client
55
quarkus.oidc.credentials.secret=secret
66
quarkus.oidc.application-type=web-app

security-openid-connect-multi-tenancy-quickstart/src/test/java/org/acme/quickstart/oidc/CodeFlowTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
@QuarkusTest
2121
public class CodeFlowTest {
2222

23-
KeycloakTestClient keycloakClient = new KeycloakTestClient();
23+
KeycloakTestClient keycloakClient = new KeycloakTestClient();
2424

2525
@Test
2626
public void testLogInDefaultTenant() throws IOException {
@@ -37,6 +37,8 @@ public void testLogInDefaultTenant() throws IOException {
3737
page = loginForm.getInputByName("login").click();
3838

3939
assertTrue(page.asText().contains("tenant"));
40+
41+
webClient.getCookieManager().clearCookies();
4042
}
4143
}
4244

@@ -55,6 +57,7 @@ public void testLogInTenantAWebApp() throws IOException {
5557
page = loginForm.getInputByName("login").click();
5658

5759
assertTrue(page.asText().contains("[email protected]"));
60+
webClient.getCookieManager().clearCookies();
5861
}
5962
}
6063

@@ -96,6 +99,8 @@ public void testReAuthenticateWhenSwitchingTenants() throws IOException {
9699
page = loginForm.getInputByName("login").click();
97100

98101
assertTrue(page.asText().contains("[email protected]"));
102+
103+
webClient.getCookieManager().clearCookies();
99104
}
100105
}
101106

security-openid-connect-quickstart/src/main/resources/application.properties

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
quarkus.oidc.client-id=backend-service
55
quarkus.oidc.credentials.secret=secret
66
quarkus.keycloak.devservices.realm-path=quarkus-realm.json
7-
quarkus.keycloak.devservices.grant.type=client
87

98
# DEBUG console logging
109
quarkus.log.console.enable=true

security-openid-connect-web-authentication-quickstart/src/main/resources/application.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ quarkus.oidc.credentials.secret=secret
55
quarkus.oidc.application-type=web-app
66
quarkus.http.auth.permission.authenticated.paths=/*
77
quarkus.http.auth.permission.authenticated.policy=authenticated
8-
quarkus.http.auth.permission.public.paths=/q/dev/*
8+
quarkus.http.auth.permission.public.paths=/q*
99
quarkus.http.auth.permission.public.policy=permit
1010
quarkus.log.category."com.gargoylesoftware.htmlunit.DefaultCssErrorHandler".level=ERROR

0 commit comments

Comments
 (0)