Update opts in Dockerfiles using ubi8 OpenJDK #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The semantics of JAVA_OPTS env is that they remove any default tuning from the UBI 8 OpenJDK image. A better suggestion would be to only append the quarkus specific options to the JVM command line. That can be done by using JAVA_OPTS_APPEND instead. Using that over JAVA_OPTS has the added benefit that users specifying JAVA_OPTS_APPEND in a deployment config would see their values show up. They wouldn't see them show up if they added an env JAVA_OPTS_APPEND, since JAVA_OPTS is specified in the Dockerfile (overriding any JAVA_OPTS_APPEND use).
gsmet
approved these changes
Nov 9, 2023
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantics of JAVA_OPTS env is that they remove any default tuning from the UBI 8 OpenJDK image. A better suggestion would be to only append the quarkus specific options to the JVM command line.
That can be done by using JAVA_OPTS_APPEND instead. Using that over JAVA_OPTS has the added benefit that users specifying JAVA_OPTS_APPEND in a deployment config would see their values show up. They wouldn't see them show up if they added an env JAVA_OPTS_APPEND, since JAVA_OPTS is specified in the Dockerfile (overriding any JAVA_OPTS_APPEND use).