Add test for onOpen exception on WS Next

Author: brunobat

extensions/websockets-next/deployment/src/test/java/io/quarkus/websockets/next/test/telemetry/MicrometerWebSocketsOnErrorTest.java

@@ -7,6 +7,7 @@
 import static io.quarkus.websockets.next.test.telemetry.MetricsAsserter.assertServerConnectionOpenedTotal;
 import static io.quarkus.websockets.next.test.telemetry.MetricsAsserter.assertServerConnectionOpeningFailedTotal;
 import static io.quarkus.websockets.next.test.telemetry.MetricsAsserter.stringToBytes;
+import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.net.URI;
@@ -22,8 +23,10 @@
 
 import io.quarkus.test.QuarkusUnitTest;
 import io.quarkus.test.common.http.TestHTTPResource;
+import io.quarkus.websockets.next.WebSocketClientConnection;
 import io.quarkus.websockets.next.WebSocketConnector;
 import io.quarkus.websockets.next.test.telemetry.endpoints.onerror.ErroneousClient_NoOnError;
+import io.quarkus.websockets.next.test.telemetry.endpoints.onerror.ErroneousClient_OnConnectError;
 import io.quarkus.websockets.next.test.telemetry.endpoints.onerror.ErroneousClient_OverloadedOnError;
 import io.quarkus.websockets.next.test.telemetry.endpoints.onerror.ErroneousServerEndpoint_OnClose;
 import io.quarkus.websockets.next.test.telemetry.endpoints.onerror.ErroneousServerEndpoint_OverriddenOnError;
@@ -43,6 +46,9 @@ public class MicrometerWebSocketsOnErrorTest {
     @Inject
     WebSocketConnector<ErroneousClient_OverloadedOnError> erroneousClientConnector_OverloadedOnErr;
 
+    @Inject
+    WebSocketConnector<ErroneousClient_OnConnectError> onConnectErrorClient;
+
     @TestHTTPResource("/")
     URI baseUri;
 
@@ -255,4 +261,22 @@ public void testServerEndpoint_HttpUpgradeFailed() {
                     .body(assertServerConnectionOpeningFailedTotal(path, 1));
         });
     }
+
+    @Test
+    public void testServerEndpoint_OnConnectionError() {
+        try {
+            WebSocketClientConnection connection = onConnectErrorClient.baseUri(baseUri).connectAndAwait();
+            connection.sendTextAndAwait("Hold the Line");
+            //            assertFalse(connection.isOpen(),
+            //                    "Runtime exception happened on server side and connection is still open");
+        } catch (Exception e) {
+            // TODO evaluate exact message received
+            assertEquals("Crafted exception - Websocket failed to open", e.getMessage());
+        }
+
+        Awaitility.await().atMost(Duration.ofSeconds(5)).untilAsserted(() -> {
+            getMetrics()
+                    .body(assertServerConnectionOpeningFailedTotal("/on-connect-error", 1));
+        });
+    }
 }

extensions/websockets-next/deployment/src/test/java/io/quarkus/websockets/next/test/telemetry/endpoints/onerror/ErroneousClient_OnConnectError.java

@@ -0,0 +1,14 @@
+package io.quarkus.websockets.next.test.telemetry.endpoints.onerror;
+
+import io.quarkus.logging.Log;
+import io.quarkus.websockets.next.OnOpen;
+import io.quarkus.websockets.next.WebSocketClient;
+
+@WebSocketClient(path = "/on-connect-error")
+public class ErroneousClient_OnConnectError {
+
+    @OnOpen()
+    public void onOpen() {
+        Log.info("client onOpen");
+    }
+}

extensions/websockets-next/deployment/src/test/java/io/quarkus/websockets/next/test/telemetry/endpoints/onerror/OnConnectErrorEndpoint.java

@@ -0,0 +1,21 @@
+package io.quarkus.websockets.next.test.telemetry.endpoints.onerror;
+
+import io.quarkus.logging.Log;
+import io.quarkus.websockets.next.OnOpen;
+import io.quarkus.websockets.next.WebSocket;
+
+@WebSocket(path = "/on-connect-error")
+public class OnConnectErrorEndpoint {
+
+    @OnOpen()
+    public void onOpen() {
+        Log.info("onOpen throwing exception");
+        throw new RuntimeException("Crafted exception - Websocket failed to open");
+    }
+
+    //    @OnTextMessage
+    //    public Uni<Dto> onMessage(Multi<Dto> dto) {
+    //        //echo
+    //        return dto.toUni();
+    //    }
+}