Skip to content

Commit 1bdd69f

Browse files
authored
Merge pull request #46255 from geoand/MongoClients-polish
Apply minor polish to MongoClients
2 parents 6adbc78 + 64f613c commit 1bdd69f

File tree

1 file changed

+10
-25
lines changed
  • extensions/mongodb-client/runtime/src/main/java/io/quarkus/mongodb/runtime

1 file changed

+10
-25
lines changed

extensions/mongodb-client/runtime/src/main/java/io/quarkus/mongodb/runtime/MongoClients.java

Lines changed: 10 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ public ClusterSettingBuilder(MongoClientConfig config) {
146146
this.config = config;
147147
}
148148

149-
private MongoClientConfig config;
149+
private final MongoClientConfig config;
150150

151151
@Override
152152
public void apply(ClusterSettings.Builder builder) {
@@ -180,8 +180,8 @@ public ConnectionPoolSettingsBuilder(MongoClientConfig config, List<ConnectionPo
180180
this.connectionPoolListeners = connectionPoolListeners;
181181
}
182182

183-
private MongoClientConfig config;
184-
private List<ConnectionPoolListener> connectionPoolListeners;
183+
private final MongoClientConfig config;
184+
private final List<ConnectionPoolListener> connectionPoolListeners;
185185

186186
@Override
187187
public void apply(ConnectionPoolSettings.Builder builder) {
@@ -211,8 +211,8 @@ public SslSettingsBuilder(MongoClientConfig config, boolean disableSslSupport) {
211211
this.disableSslSupport = disableSslSupport;
212212
}
213213

214-
private MongoClientConfig config;
215-
private boolean disableSslSupport;
214+
private final MongoClientConfig config;
215+
private final boolean disableSslSupport;
216216

217217
@Override
218218
public void apply(SslSettings.Builder builder) {
@@ -225,7 +225,7 @@ public SocketSettingsBuilder(MongoClientConfig config) {
225225
this.config = config;
226226
}
227227

228-
private MongoClientConfig config;
228+
private final MongoClientConfig config;
229229

230230
@Override
231231
public void apply(SocketSettings.Builder builder) {
@@ -243,7 +243,7 @@ public ServerSettingsBuilder(MongoClientConfig config) {
243243
this.config = config;
244244
}
245245

246-
private MongoClientConfig config;
246+
private final MongoClientConfig config;
247247

248248
@Override
249249
public void apply(ServerSettings.Builder builder) {
@@ -466,8 +466,8 @@ private MongoCredential createMongoCredential(MongoClientConfig config) {
466466
usernamePassword = new UsernamePassword(null, null);
467467
}
468468
// Create the MongoCredential instance.
469-
String username = usernamePassword.getUsername();
470-
char[] password = usernamePassword.getPassword();
469+
String username = usernamePassword.username();
470+
char[] password = usernamePassword.password();
471471
MongoCredential credential;
472472
if (mechanism == GSSAPI) {
473473
credential = MongoCredential.createGSSAPICredential(username);
@@ -540,21 +540,6 @@ public void stop() {
540540
}
541541
}
542542

543-
private static class UsernamePassword {
544-
private final String username;
545-
private final char[] password;
546-
547-
public UsernamePassword(String username, char[] password) {
548-
this.username = username;
549-
this.password = password;
550-
}
551-
552-
public String getUsername() {
553-
return username;
554-
}
555-
556-
public char[] getPassword() {
557-
return password;
558-
}
543+
private record UsernamePassword(String username, char[] password) {
559544
}
560545
}

0 commit comments

Comments
 (0)