Skip to content

Commit 22f038e

Browse files
Blaz Mrakblazmrak
authored andcommitted
Updated RuntimeParamConverterTest with the new empty parameter behavior
1 parent f7d00c6 commit 22f038e

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

extensions/resteasy-reactive/rest/deployment/src/test/java/io/quarkus/resteasy/reactive/server/test/converters/RuntimeParamConverterTest.java

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ void sendEmptyParameter() {
6161
.when().get("/param-converter")
6262
.then()
6363
.statusCode(200)
64-
.body(Matchers.is("Hello! You provided an empty number."));
64+
.body(Matchers.is("Hello, world! No number was provided."));
6565
}
6666

6767
@ApplicationScoped
@@ -70,12 +70,8 @@ public static class ParamConverterEndpoint {
7070

7171
@GET
7272
public Response greet(@QueryParam("number") Optional<Integer> numberOpt) {
73-
if (numberOpt != null) {
74-
if (numberOpt.isPresent()) {
75-
return Response.ok(String.format("Hello, %s!", numberOpt.get())).build();
76-
} else {
77-
return Response.ok("Hello! You provided an empty number.").build();
78-
}
73+
if (numberOpt.isPresent()) {
74+
return Response.ok(String.format("Hello, %s!", numberOpt.get())).build();
7975
} else {
8076
return Response.ok("Hello, world! No number was provided.").build();
8177
}
@@ -108,10 +104,6 @@ public static class OptionalIntegerParamConverter implements ParamConverter<Opti
108104
@Override
109105
public Optional<Integer> fromString(String value) {
110106
if (value == null) {
111-
return null;
112-
}
113-
114-
if (value.trim().isEmpty()) {
115107
return Optional.empty();
116108
}
117109

0 commit comments

Comments
 (0)