Skip to content

Commit 27dcd70

Browse files
committed
Improve logging in DevServicesKubernetesProcessor
The current implementation is very vocal and annoying as you end up with an info logging before the Quarkus banner in a lot of cases. Also improved the naming consistency in other messages.
1 parent 181dae5 commit 27dcd70

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

extensions/kubernetes-client/deployment-internal/src/main/java/io/quarkus/kubernetes/client/deployment/DevServicesKubernetesProcessor.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -163,23 +163,23 @@ private RunningDevService startKubernetes(DockerStatusBuildItem dockerStatusBuil
163163
LaunchModeBuildItem launchMode, boolean useSharedNetwork, Optional<Duration> timeout) {
164164
if (!config.devServicesEnabled) {
165165
// explicitly disabled
166-
log.debug("Not starting dev services for Kubernetes, as it has been disabled in the config.");
166+
log.debug("Not starting Dev Services for Kubernetes, as it has been disabled in the config.");
167167
return null;
168168
}
169169

170170
// Check if kubernetes-client.master-url is set
171171
if (ConfigUtils.isPropertyPresent(KUBERNETES_CLIENT_MASTER_URL)) {
172-
log.info("Not starting dev services for Kubernetes, the " + KUBERNETES_CLIENT_MASTER_URL + " is configured.");
172+
log.debug("Not starting Dev Services for Kubernetes, the " + KUBERNETES_CLIENT_MASTER_URL + " is configured.");
173173
return null;
174174
}
175175

176176
if (!config.overrideKubeconfig) {
177177
var autoConfigMasterUrl = Config.autoConfigure(null).getMasterUrl();
178178
if (!DEFAULT_MASTER_URL_ENDING_WITH_SLASH.equals(autoConfigMasterUrl)) {
179-
log.info(
180-
"Not starting dev services for Kubernetes, the kubernetes client is auto-configured. Set "
179+
log.debug(
180+
"Not starting Dev Services for Kubernetes, the Kubernetes client is auto-configured. Set "
181181
+ KUBERNETES_CLIENT_DEVSERVICES_OVERRIDE_KUBECONFIG
182-
+ " to true to use dev services for Kubernetes.");
182+
+ " to true to use Dev Services for Kubernetes.");
183183
return null;
184184
}
185185
}
@@ -213,7 +213,7 @@ private RunningDevService startKubernetes(DockerStatusBuildItem dockerStatusBuil
213213
.orElseGet(() -> latest(KindContainerVersion.class)));
214214
break;
215215
default:
216-
throw new RuntimeException(KUBERNETES_CLIENT_DEVSERVICES_FLAVOR + "must be a valid Flavor enum value.");
216+
throw new RuntimeException(KUBERNETES_CLIENT_DEVSERVICES_FLAVOR + " must be a valid Flavor enum value.");
217217
}
218218

219219
if (useSharedNetwork) {
@@ -350,7 +350,7 @@ public Map<String, String> getKubeconfig() {
350350
// this can happen only if the user manually start
351351
// a DEV_SERVICE_LABEL labeled container with an invalid image name
352352
throw new RuntimeException("The container with the label '" + DEV_SERVICE_LABEL
353-
+ "' is not compatible with dev service for Kubernetes. Stop it or disable dev services for Kubernetes.");
353+
+ "' is not compatible with Dev Services for Kubernetes. Stop it or disable Dev Services for Kubernetes.");
354354
}
355355

356356
protected KubeConfig getKubeconfigFromApiContainer(final String url) {

0 commit comments

Comments
 (0)