Skip to content

Commit 33ca1bb

Browse files
holly-cumminsgsmet
andcommitted
Do not do docker prune (that we don't do anyway), update readme
Co-Authored-By: Guillaume Smet <[email protected]>
1 parent 9e380b4 commit 33ca1bb

File tree

5 files changed

+7
-93
lines changed

5 files changed

+7
-93
lines changed

integration-tests/hibernate-reactive-oracle/pom.xml

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -166,35 +166,6 @@
166166
</build>
167167
</profile>
168168

169-
<profile>
170-
<id>docker-oracle</id>
171-
<activation>
172-
<property>
173-
<name>start-containers</name>
174-
</property>
175-
</activation>
176-
<build>
177-
<plugins>
178-
<plugin>
179-
<groupId>org.codehaus.mojo</groupId>
180-
<artifactId>exec-maven-plugin</artifactId>
181-
<executions>
182-
<execution>
183-
<id>docker-prune</id>
184-
<phase>generate-resources</phase>
185-
<goals>
186-
<goal>exec</goal>
187-
</goals>
188-
<configuration>
189-
<executable>${docker-prune.location}</executable>
190-
</configuration>
191-
</execution>
192-
</executions>
193-
</plugin>
194-
</plugins>
195-
</build>
196-
</profile>
197-
198169
<!-- Disabled pending fix of #33094 -->
199170
<profile>
200171
<id>podman</id>

integration-tests/jpa-oracle/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
## Running the tests
44

55

6-
To run the tests in a standard JVM with an Oracle database started as a Docker container, you can run the following command:
6+
To run the tests in a standard JVM with an Oracle database started as a Dev Service, you can run the following command:
77

88
```
99
mvn verify -Dtest-containers -Dstart-containers
@@ -17,13 +17,13 @@ mvn verify -Dtest-containers -Dstart-containers -Dnative
1717

1818
Alternatively you can connect to your own Oracle database.
1919
Reconfigure the connection URL with `-Doracledb.url=jdbc:Oracle://...`;
20-
Authentication parameters might need to be changed in the Quarkus configuration file `application.properties`.
20+
Authentication parameters might need to be added in the Quarkus configuration file `application.properties`.
2121

2222
### Starting Oracle via docker
2323

2424
```
2525
docker run --rm=true --name=HibernateTestingOracle -p 1521:1521 -e ORACLE_PASSWORD=hibernate_orm_test docker.io/gvenzl/oracle-free:23-slim-faststart
2626
```
2727

28-
This will start a local instance with the configuration matching the parameters used by the integration tests of this module.
28+
This will start a local instance. Update `application.properties` with the new configuration.
2929

integration-tests/jpa-oracle/pom.xml

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -174,35 +174,6 @@
174174
</plugins>
175175
</build>
176176
</profile>
177-
178-
<profile>
179-
<id>docker-oracle</id>
180-
<activation>
181-
<property>
182-
<name>start-containers</name>
183-
</property>
184-
</activation>
185-
<build>
186-
<plugins>
187-
<plugin>
188-
<groupId>org.codehaus.mojo</groupId>
189-
<artifactId>exec-maven-plugin</artifactId>
190-
<executions>
191-
<execution>
192-
<id>docker-prune</id>
193-
<phase>generate-resources</phase>
194-
<goals>
195-
<goal>exec</goal>
196-
</goals>
197-
<configuration>
198-
<executable>${docker-prune.location}</executable>
199-
</configuration>
200-
</execution>
201-
</executions>
202-
</plugin>
203-
</plugins>
204-
</build>
205-
</profile>
206177
</profiles>
207178

208179
</project>

integration-tests/reactive-oracle-client/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# Reactive Oracle example
22

3+
34
## Running the tests
45

5-
By default, the tests of this module are disabled.
66

7-
To run the tests in a standard JVM with an Oracle database started as a Docker container, you can run the following command:
7+
To run the tests in a standard JVM with an Oracle database started as a Dev Service, you can run the following command:
88

99
```
1010
mvn verify -Dtest-containers -Dstart-containers
@@ -18,12 +18,12 @@ mvn verify -Dtest-containers -Dstart-containers -Dnative
1818

1919
Alternatively you can connect to your own Oracle database.
2020
Reconfigure the connection URL with `-Dreactive-oracledb.url=jdbc:oracle:thin:...`;
21-
Authentication parameters might need to be changed in the Quarkus configuration file `application.properties`.
21+
Authentication parameters might need to be added in the Quarkus configuration file `application.properties`.
2222

2323
### Starting Oracle via docker
2424

2525
```
2626
docker run --rm=true --name=HibernateTestingOracle -p 1521:1521 -e ORACLE_PASSWORD=hibernate_orm_test docker.io/gvenzl/oracle-free:23-slim-faststart
2727
```
2828

29-
This will start a local instance with the configuration matching the parameters used by the integration tests of this module.
29+
This will start a local instance. Update `application.properties` with the new configuration.

integration-tests/reactive-oracle-client/pom.xml

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -140,34 +140,6 @@
140140
</plugins>
141141
</build>
142142
</profile>
143-
<profile>
144-
<id>docker-oracle</id>
145-
<activation>
146-
<property>
147-
<name>start-containers</name>
148-
</property>
149-
</activation>
150-
<build>
151-
<plugins>
152-
<plugin>
153-
<groupId>org.codehaus.mojo</groupId>
154-
<artifactId>exec-maven-plugin</artifactId>
155-
<executions>
156-
<execution>
157-
<id>docker-prune</id>
158-
<phase>generate-resources</phase>
159-
<goals>
160-
<goal>exec</goal>
161-
</goals>
162-
<configuration>
163-
<executable>${docker-prune.location}</executable>
164-
</configuration>
165-
</execution>
166-
</executions>
167-
</plugin>
168-
</plugins>
169-
</build>
170-
</profile>
171143
</profiles>
172144

173145
</project>

0 commit comments

Comments
 (0)