Skip to content

Commit 4028677

Browse files
authored
Merge pull request #50165 from metacosm/fix-dev-service-equals
Fix improper equals method implementation
2 parents c355083 + d7bf7a6 commit 4028677

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

extensions/kubernetes-client/deployment/src/main/java/io/quarkus/kubernetes/client/deployment/DevServicesKubernetesProcessor.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -482,9 +482,13 @@ public boolean equals(Object obj) {
482482
return true;
483483
if (!(obj instanceof KubernetesDevServiceCfg other))
484484
return false;
485-
return devServicesEnabled == other.devServicesEnabled && flavor == other.flavor
486-
&& Objects.equals(apiVersion, other.apiVersion) && overrideKubeconfig == other.overrideKubeconfig
487-
&& shared == other.shared && Objects.equals(serviceName, other.serviceName)
485+
return devServicesEnabled == other.devServicesEnabled
486+
&& Objects.equals(imageName, other.imageName)
487+
&& Objects.equals(flavor, other.flavor)
488+
&& Objects.equals(apiVersion, other.apiVersion)
489+
&& overrideKubeconfig == other.overrideKubeconfig
490+
&& shared == other.shared
491+
&& Objects.equals(serviceName, other.serviceName)
488492
&& Objects.equals(containerEnv, other.containerEnv);
489493
}
490494
}

0 commit comments

Comments
 (0)