ArC: improve the invoker API

Author: Ladicek

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/InvocationTransformer.java

@@ -20,7 +20,7 @@ public String toString() {
             case EXCEPTION -> "exception transformer ";
             case WRAPPER -> "invocation wrapper ";
         };
-        return kind + clazz.getName() + "#" + method;
+        return kind + clazz.getName() + "." + method + "()";
     }
 
     public boolean isInputTransformer() {

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/InvokerBuilder.java

@@ -110,8 +110,9 @@
  * <p>
  * For the purpose of the specification of transformers and wrappers below, the term
  * <em>any-type</em> is recursively defined as: the {@code java.lang.Object} class type,
- * or a type variable that has no bound, or a type variable whose first bound is
- * <em>any-type</em>.
+ * or a type variable that has no bound, or a type variable whose first bound (including
+ * an implicitly declared {@code java.lang.Object} bound in case all declared bounds are
+ * interface types) is <em>any-type</em>.
  *
  * <h2>Input transformations</h2>
  *

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/InvokerInfo.java

@@ -1,5 +1,6 @@
 package io.quarkus.arc.processor;
 
+import java.lang.constant.ClassDesc;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
@@ -13,6 +14,7 @@
  * Opaque token that stands in for an invoker built using {@link InvokerBuilder}.
  *
  * @see #getClassName()
+ * @see #getClassDesc()
  */
 public class InvokerInfo implements InjectionTargetInfo {
     private final BeanDeployment beanDeployment;
@@ -94,7 +96,10 @@ private static String methodHash(InvokerBuilder builder) {
     /**
      * Returns the class name of the built invoker. It is guaranteed to have a {@code public}
      * zero-parameter constructor.
+     *
+     * @deprecated use {@link #getClassDesc()}
      */
+    @Deprecated(forRemoval = true, since = "3.30")
     public String getClassName() {
         if (lazyClassName != null) {
             return lazyClassName;
@@ -105,6 +110,14 @@ public String getClassName() {
         }
     }
 
+    /**
+     * Returns the class of the built invoker. It is guaranteed to have a {@code public}
+     * zero-parameter constructor.
+     */
+    public ClassDesc getClassDesc() {
+        return ClassDesc.of(getClassName());
+    }
+
     @Override
     public String toString() {
         return "invoker of " + targetBeanClass.name() + "#" + method.name();

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/SyntheticComponentsUtil.java

@@ -352,11 +352,11 @@ static void addParamsFieldAndInit_2(io.quarkus.gizmo2.creator.ClassCreator cc, B
                         bc.set(value.elem(i), annotationLiterals.create(bc, annotationClass, annotationInstance));
                     }
                 } else if (entry.getValue() instanceof InvokerInfo val) {
-                    value = bc.localVar("value", bc.new_(ClassDesc.of(val.getClassName())));
+                    value = bc.localVar("value", bc.new_(val.getClassDesc()));
                 } else if (entry.getValue() instanceof InvokerInfo[] array) {
                     value = bc.localVar("value", bc.newEmptyArray(Invoker.class, array.length));
                     for (int i = 0; i < array.length; i++) {
-                        bc.set(value.elem(i), bc.new_(ClassDesc.of(array[i].getClassName())));
+                        bc.set(value.elem(i), bc.new_(array[i].getClassDesc()));
                     }
                 } else {
                     throw new IllegalArgumentException("Unsupported parameter type: " + entry.getValue());