Skip to content

Commit 4bf78d6

Browse files
authored
Merge pull request #50597 from Karm/issue-50568
container-image-docker-common: swallow stderr on success
2 parents 4c8d336 + 7e6e0c0 commit 4bf78d6

File tree

1 file changed

+8
-2
lines changed
  • extensions/container-image/container-image-docker-common/deployment/src/main/java/io/quarkus/container/image/docker/common/deployment

1 file changed

+8
-2
lines changed

extensions/container-image/container-image-docker-common/deployment/src/main/java/io/quarkus/container/image/docker/common/deployment/CommonProcessor.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ protected void loginToRegistryIfNeeded(ContainerImageConfig containerImageConfig
167167
ProcessBuilder.newBuilder(executableName)
168168
.arguments("login", registry, "-u", containerImageConfig.username().get(), "-p",
169169
containerImageConfig.password().get())
170+
.error().logOnSuccess(false).inherited()
170171
.run();
171172
}
172173
}
@@ -200,7 +201,9 @@ protected void createAdditionalTags(String image, List<String> additionalImageTa
200201
.map(additionalTag -> new String[] { "tag", image, additionalTag })
201202
.forEach(tagArgs -> {
202203
LOGGER.infof("Running '%s %s'", executableName, String.join(" ", tagArgs));
203-
ProcessBuilder.exec(executableName, tagArgs);
204+
ProcessBuilder.newBuilder(executableName).arguments(tagArgs)
205+
.error().logOnSuccess(false).inherited()
206+
.run();
204207
});
205208
}
206209

@@ -214,7 +217,9 @@ protected void pushImages(ContainerImageInfoBuildItem containerImageInfo, String
214217
}
215218

216219
protected void pushImage(String image, String executableName, C config) {
217-
ProcessBuilder.exec(executableName, createPushArgs(image, config));
220+
ProcessBuilder.newBuilder(executableName).arguments(createPushArgs(image, config))
221+
.error().logOnSuccess(false).inherited()
222+
.run();
218223
LOGGER.infof("Successfully pushed %s image %s", getProcessorImplementation(), image);
219224
}
220225

@@ -233,6 +238,7 @@ protected void buildImage(ContainerImageInfoBuildItem containerImageInfo,
233238
ProcessBuilder.newBuilder(executableName)
234239
.directory(out.getOutputDirectory())
235240
.arguments(args)
241+
.error().logOnSuccess(false).inherited()
236242
.run();
237243

238244
if (createAdditionalTags && !containerImageInfo.getAdditionalImageTags().isEmpty()) {

0 commit comments

Comments
 (0)