PoC: integrate Eclipse Formatter Profile into Maven Spotless Plugin

Vincent Potucek · Pankraz76 · commit 5783bdd3db2f · 2025-05-24T22:46:18.000+02:00
diff --git a/build-parent/pom.xml b/build-parent/pom.xml
@@ -677,8 +677,47 @@
                     <artifactId>smallrye-certificate-generator-maven-plugin</artifactId>
                     <version>${smallrye-certificate-generator.version}</version>
                 </plugin>
+                <plugin>
+                    <groupId>com.diffplug.spotless</groupId>
+                    <artifactId>spotless-maven-plugin</artifactId>
+                    <version>2.44.4</version>
+                    <configuration>
+                        <java>
+                            <removeUnusedImports />
+                            <formatAnnotations />
+                            <eclipse>
+                                <file>${maven.multiModuleProjectDirectory}/independent-projects/ide-config/src/main/resources/eclipse-format.xml</file>
+                            </eclipse>
+                            <importOrder>
+                                <file>${maven.multiModuleProjectDirectory}/independent-projects/ide-config/src/main/resources/eclipse.importorder</file>
+                            </importOrder>
+                        </java>
+                    </configuration>
+                    <executions>
+<!--                        <execution>-->
+<!--                            <id>spotless-check</id>-->
+<!--                            <goals>-->
+<!--                                <goal>apply</goal>-->
+<!--                            </goals>-->
+<!--                            <phase>verify</phase>-->
+<!--                        </execution>-->
+                        <execution>
+                            <id>spotless-apply</id>
+                            <goals>
+                                 <goal>apply</goal>
+                            </goals>
+                            <phase>verify</phase>
+                        </execution>
+                    </executions>
+                </plugin>
             </plugins>
         </pluginManagement>
+        <plugins>
+            <plugin>
+                <groupId>com.diffplug.spotless</groupId>
+                <artifactId>spotless-maven-plugin</artifactId>
+            </plugin>
+        </plugins>
     </build>
 
     <profiles>
@@ -779,7 +818,6 @@
                     <plugin>
                         <groupId>com.diffplug.spotless</groupId>
                         <artifactId>spotless-maven-plugin</artifactId>
-                        <version>2.35.0</version>
                         <executions>
                             <execution>
                                 <id>format-kotlin</id>
diff --git a/extensions/grpc/deployment/src/test/java/io/quarkus/grpc/client/bd/ClientBlockingDeadlineTest.java b/extensions/grpc/deployment/src/test/java/io/quarkus/grpc/client/bd/ClientBlockingDeadlineTest.java
@@ -1,6 +1,5 @@
 package io.quarkus.grpc.client.bd;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 
 import org.jboss.shrinkwrap.api.ShrinkWrap;
diff --git a/extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/proxies/ProxyDefinitions.java b/extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/proxies/ProxyDefinitions.java
@@ -13,7 +13,6 @@
 import org.hibernate.internal.util.ReflectHelper;
 import org.hibernate.internal.util.collections.ArrayHelper;
 import org.hibernate.mapping.PersistentClass;
-import org.hibernate.proxy.pojo.ProxyFactoryHelper;
 import org.hibernate.proxy.pojo.bytebuddy.ByteBuddyProxyHelper;
 import org.jboss.logging.Logger;
 
diff --git a/extensions/kubernetes/spi/src/test/java/io/quarkus/kubernetes/spi/KubernetesEnvBuildItemTest.java b/extensions/kubernetes/spi/src/test/java/io/quarkus/kubernetes/spi/KubernetesEnvBuildItemTest.java
@@ -13,10 +13,10 @@
  */
 package io.quarkus.kubernetes.spi;
 
-import static io.quarkus.kubernetes.spi.KubernetesEnvBuildItem.create;
 import static io.quarkus.kubernetes.spi.KubernetesEnvBuildItem.EnvType.configmap;
 import static io.quarkus.kubernetes.spi.KubernetesEnvBuildItem.EnvType.secret;
 import static io.quarkus.kubernetes.spi.KubernetesEnvBuildItem.EnvType.var;
+import static io.quarkus.kubernetes.spi.KubernetesEnvBuildItem.create;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNull;
 
diff --git a/extensions/redis-client/runtime/src/main/java/io/quarkus/redis/datasource/keys/KeyCommands.java b/extensions/redis-client/runtime/src/main/java/io/quarkus/redis/datasource/keys/KeyCommands.java
@@ -3,7 +3,6 @@
 import java.time.Duration;
 import java.time.Instant;
 import java.util.List;
-import java.util.Set;
 
 import io.quarkus.redis.datasource.RedisCommands;
 
diff --git a/extensions/redis-client/runtime/src/main/java/io/quarkus/redis/datasource/keys/ReactiveKeyCommands.java b/extensions/redis-client/runtime/src/main/java/io/quarkus/redis/datasource/keys/ReactiveKeyCommands.java
@@ -3,7 +3,6 @@
 import java.time.Duration;
 import java.time.Instant;
 import java.util.List;
-import java.util.Set;
 
 import io.quarkus.redis.datasource.ReactiveRedisCommands;
 import io.smallrye.mutiny.Uni;
diff --git a/extensions/redis-client/runtime/src/main/java/io/quarkus/redis/datasource/search/SummarizeArgs.java b/extensions/redis-client/runtime/src/main/java/io/quarkus/redis/datasource/search/SummarizeArgs.java
@@ -2,7 +2,6 @@
 
 import static io.quarkus.redis.runtime.datasource.Validation.notNullOrBlank;
 import static io.quarkus.redis.runtime.datasource.Validation.notNullOrEmpty;
-import static io.smallrye.mutiny.helpers.ParameterValidation.doesNotContainNull;
 import static io.smallrye.mutiny.helpers.ParameterValidation.positive;
 
 import java.util.ArrayList;
diff --git a/extensions/redis-client/runtime/src/test/java/io/quarkus/redis/datasource/AutoSuggestCommandsTest.java b/extensions/redis-client/runtime/src/test/java/io/quarkus/redis/datasource/AutoSuggestCommandsTest.java
@@ -1,7 +1,6 @@
 package io.quarkus.redis.datasource;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.awaitility.Awaitility.await;
 
 import java.time.Duration;
 import java.util.List;
diff --git a/extensions/redis-client/runtime/src/test/java/io/quarkus/redis/datasource/BitMapCommandsTest.java b/extensions/redis-client/runtime/src/test/java/io/quarkus/redis/datasource/BitMapCommandsTest.java
@@ -1,10 +1,10 @@
 package io.quarkus.redis.datasource;
 
+import static io.quarkus.redis.datasource.bitmap.BitFieldArgs.OverflowType.WRAP;
 import static io.quarkus.redis.datasource.bitmap.BitFieldArgs.offset;
 import static io.quarkus.redis.datasource.bitmap.BitFieldArgs.signed;
 import static io.quarkus.redis.datasource.bitmap.BitFieldArgs.typeWidthBasedOffset;
 import static io.quarkus.redis.datasource.bitmap.BitFieldArgs.unsigned;
-import static io.quarkus.redis.datasource.bitmap.BitFieldArgs.OverflowType.WRAP;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
diff --git a/extensions/resteasy-classic/resteasy/deployment/src/test/java/io/quarkus/resteasy/test/security/inheritance/AbstractImplMethodSecuredTest.java b/extensions/resteasy-classic/resteasy/deployment/src/test/java/io/quarkus/resteasy/test/security/inheritance/AbstractImplMethodSecuredTest.java
@@ -21,7 +21,6 @@
 import static io.quarkus.resteasy.test.security.inheritance.SubPaths.SUB_IMPL_ON_INTERFACE;
 import static io.quarkus.resteasy.test.security.inheritance.SubPaths.SUB_IMPL_ON_PARENT;
 import static io.restassured.RestAssured.given;
-import static org.hamcrest.Matchers.in;
 import static org.hamcrest.Matchers.is;
 
 import org.jboss.shrinkwrap.api.asset.StringAsset;
diff --git a/extensions/resteasy-reactive/rest-client/deployment/src/test/java/io/quarkus/rest/client/reactive/InterfacePathInheritanceTest.java b/extensions/resteasy-reactive/rest-client/deployment/src/test/java/io/quarkus/rest/client/reactive/InterfacePathInheritanceTest.java
@@ -1,6 +1,5 @@
 package io.quarkus.rest.client.reactive;
 
-import static org.assertj.core.api.Assertions.assertThat;
 import static org.hamcrest.Matchers.is;
 
 import java.util.Map;
diff --git a/extensions/resteasy-reactive/rest-jackson/deployment/src/test/java/io/quarkus/resteasy/reactive/jackson/deployment/test/ResponseType.java b/extensions/resteasy-reactive/rest-jackson/deployment/src/test/java/io/quarkus/resteasy/reactive/jackson/deployment/test/ResponseType.java
@@ -5,7 +5,6 @@
 import org.jboss.resteasy.reactive.RestResponse;
 
 import io.quarkus.resteasy.reactive.jackson.SecureField;
-import io.smallrye.mutiny.Multi;
 import io.smallrye.mutiny.Uni;
 
 public enum ResponseType {
diff --git a/extensions/resteasy-reactive/rest-kotlin/deployment/src/main/java/io/quarkus/resteasy/reactive/kotlin/deployment/KotlinCoroutineIntegrationProcessor.java b/extensions/resteasy-reactive/rest-kotlin/deployment/src/main/java/io/quarkus/resteasy/reactive/kotlin/deployment/KotlinCoroutineIntegrationProcessor.java
@@ -11,7 +11,6 @@
 import org.jboss.jandex.DotName;
 import org.jboss.jandex.MethodInfo;
 import org.jboss.jandex.Type;
-import org.jboss.resteasy.reactive.common.model.ResourceMethod;
 import org.jboss.resteasy.reactive.common.processor.EndpointIndexer;
 import org.jboss.resteasy.reactive.common.processor.HashUtil;
 import org.jboss.resteasy.reactive.server.core.parameters.NullParamExtractor;
diff --git a/extensions/resteasy-reactive/rest-kotlin/runtime/src/main/kotlin/org/jboss/resteasy/reactive/server/runtime/kotlin/AbstractSuspendedRequestFilter.kt b/extensions/resteasy-reactive/rest-kotlin/runtime/src/main/kotlin/org/jboss/resteasy/reactive/server/runtime/kotlin/AbstractSuspendedRequestFilter.kt
@@ -21,7 +21,7 @@ abstract class AbstractSuspendedRequestFilter : ResteasyReactiveContainerRequest
 
     abstract fun handleResult(
         containerRequestContext: ResteasyReactiveContainerRequestContext,
-        uniResult: Uni<*>
+        uniResult: Uni<*>,
     )
 
     private val originalTCCL: ClassLoader = Thread.currentThread().contextClassLoader
diff --git a/extensions/resteasy-reactive/rest-kotlin/runtime/src/main/kotlin/org/jboss/resteasy/reactive/server/runtime/kotlin/AbstractSuspendedResponseFilter.kt b/extensions/resteasy-reactive/rest-kotlin/runtime/src/main/kotlin/org/jboss/resteasy/reactive/server/runtime/kotlin/AbstractSuspendedResponseFilter.kt
@@ -16,14 +16,14 @@ abstract class AbstractSuspendedResponseFilter : ResteasyReactiveContainerRespon
 
     abstract suspend fun doFilter(
         requestContext: ResteasyReactiveContainerRequestContext,
-        responseContext: ContainerResponseContext
+        responseContext: ContainerResponseContext,
     ): Any
 
     private val originalTCCL: ClassLoader = Thread.currentThread().contextClassLoader
 
     override fun filter(
         requestContext: ResteasyReactiveContainerRequestContext,
-        responseContext: ContainerResponseContext
+        responseContext: ContainerResponseContext,
     ) {
         val (dispatcher, coroutineScope) =
             prepareExecution(requestContext.serverRequestContext as ResteasyReactiveRequestContext)
diff --git a/extensions/resteasy-reactive/rest-kotlin/runtime/src/main/kotlin/org/jboss/resteasy/reactive/server/runtime/kotlin/ApplicationCoroutineScope.kt b/extensions/resteasy-reactive/rest-kotlin/runtime/src/main/kotlin/org/jboss/resteasy/reactive/server/runtime/kotlin/ApplicationCoroutineScope.kt
@@ -34,7 +34,7 @@ class ApplicationCoroutineScope : CoroutineScope, AutoCloseable {
 class VertxDispatcher(
     private val vertxContext: Context,
     private val requestScope: ThreadSetupAction.ThreadState,
-    private val rrContext: ResteasyReactiveRequestContext
+    private val rrContext: ResteasyReactiveRequestContext,
 ) : CoroutineDispatcher() {
     override fun dispatch(context: CoroutineContext, block: Runnable) {
         // context propagation for suspending functions is not enabled yet, will be handled later
diff --git a/extensions/resteasy-reactive/rest-kotlin/runtime/src/main/kotlin/org/jboss/resteasy/reactive/server/runtime/kotlin/CoroutineInvocationHandler.kt b/extensions/resteasy-reactive/rest-kotlin/runtime/src/main/kotlin/org/jboss/resteasy/reactive/server/runtime/kotlin/CoroutineInvocationHandler.kt
@@ -14,7 +14,7 @@ private val logger = LoggerFactory.getLogger(CoroutineInvocationHandler::class.j
 
 class CoroutineInvocationHandler(
     private val invoker: EndpointInvoker,
-    private val coroutineScope: CoroutineScope
+    private val coroutineScope: CoroutineScope,
 ) : ServerRestHandler {
 
     private val originalTCCL: ClassLoader = Thread.currentThread().contextClassLoader
@@ -47,7 +47,7 @@ class CoroutineInvocationHandler(
                     val result =
                         invoker.invokeCoroutine(
                             requestContext.endpointInstance,
-                            requestContext.parameters
+                            requestContext.parameters,
                         )
                     done.set(true)
                     if (result != Unit) {
diff --git a/extensions/resteasy-reactive/rest/deployment/src/test/java/io/quarkus/resteasy/reactive/server/test/customproviders/OptionsRequestTest.java b/extensions/resteasy-reactive/rest/deployment/src/test/java/io/quarkus/resteasy/reactive/server/test/customproviders/OptionsRequestTest.java
@@ -1,7 +1,6 @@
 package io.quarkus.resteasy.reactive.server.test.customproviders;
 
 import static io.restassured.RestAssured.when;
-import static org.hamcrest.Matchers.contains;
 import static org.hamcrest.Matchers.emptyOrNullString;
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.is;
diff --git a/extensions/smallrye-context-propagation/runtime/src/main/java/io/quarkus/smallrye/context/runtime/SmallRyeContextPropagationRecorder.java b/extensions/smallrye-context-propagation/runtime/src/main/java/io/quarkus/smallrye/context/runtime/SmallRyeContextPropagationRecorder.java
@@ -12,7 +12,6 @@
 
 import org.eclipse.microprofile.context.ManagedExecutor;
 import org.eclipse.microprofile.context.ThreadContext;
-import org.eclipse.microprofile.context.spi.ContextManager.Builder;
 import org.eclipse.microprofile.context.spi.ContextManagerExtension;
 import org.eclipse.microprofile.context.spi.ContextManagerProvider;
 import org.eclipse.microprofile.context.spi.ThreadContextProvider;
diff --git a/extensions/vertx-http/deployment/src/test/java/io/quarkus/vertx/http/RootPathTest.java b/extensions/vertx-http/deployment/src/test/java/io/quarkus/vertx/http/RootPathTest.java
@@ -1,7 +1,5 @@
 package io.quarkus.vertx.http;
 
-import static io.restassured.RestAssured.given;
-
 import jakarta.enterprise.context.ApplicationScoped;
 import jakarta.enterprise.event.Observes;
 
diff --git a/extensions/vertx-http/deployment/src/test/java/io/quarkus/vertx/http/proxy/fakedns/DnsMessageEncoder.java b/extensions/vertx-http/deployment/src/test/java/io/quarkus/vertx/http/proxy/fakedns/DnsMessageEncoder.java
@@ -7,25 +7,6 @@
 import java.util.List;
 import java.util.Map;
 
-/*
- *  Licensed to the Apache Software Foundation (ASF) under one
- *  or more contributor license agreements.  See the NOTICE file
- *  distributed with this work for additional information
- *  regarding copyright ownership.  The ASF licenses this file
- *  to you under the Apache License, Version 2.0 (the
- *  "License"); you may not use this file except in compliance
- *  with the License.  You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing,
- *  software distributed under the License is distributed on an
- *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- *  KIND, either express or implied.  See the License for the
- *  specific language governing permissions and limitations
- *  under the License.
- *
- */
 import org.apache.directory.server.dns.io.encoder.*;
 import org.apache.directory.server.dns.messages.DnsMessage;
 import org.apache.directory.server.dns.messages.MessageType;
