Skip to content

Commit 59b5b3c

Browse files
authored
Merge pull request #50032 from fedinskiy/strimzi-update
Update Strimzi from 0.109.2 to 0.112.0
2 parents b651a3d + 83704ec commit 59b5b3c

File tree

10 files changed

+16
-18
lines changed

10 files changed

+16
-18
lines changed

bom/application/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@
143143
<kafka3.version>4.0.0</kafka3.version>
144144
<lz4.version>1.8.0</lz4.version> <!-- dependency of the kafka-clients that could be overridden by other imported BOMs in the platform -->
145145
<snappy.version>1.1.10.5</snappy.version>
146-
<strimzi-test-container.version>0.109.2</strimzi-test-container.version>
146+
<strimzi-test-container.version>0.112.0</strimzi-test-container.version>
147147
<!-- Scala is used by Kafka so we need to choose a compatible version -->
148148
<scala.version>2.13.16</scala.version>
149149
<aws-lambda-java.version>1.4.0</aws-lambda-java.version>

bom/test/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<jaxb-api.version>2.3.1</jaxb-api.version>
2121

2222
<rxjava1.version>1.3.8</rxjava1.version>
23-
<strimzi-test-container.version>0.109.2</strimzi-test-container.version>
23+
<strimzi-test-container.version>0.112.0</strimzi-test-container.version>
2424

2525
<opentelemetry-proto.version>1.3.2-alpha</opentelemetry-proto.version>
2626
</properties>

extensions/kafka-client/deployment/src/main/java/io/quarkus/kafka/client/deployment/DevServicesKafkaProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@ private Startable createContainer(DevServicesComposeProjectBuildItem composeProj
109109
.withSharedServiceLabel(launchMode.getLaunchMode(), config.serviceName());
110110
case STRIMZI -> {
111111
StrimziKafkaContainer strimzi = new StrimziKafkaContainer(config.effectiveImageName())
112+
.withNodeId(1)
112113
.withBrokerId(1)
113-
.withKraft()
114114
.waitForRunning();
115115
String hostName = ConfigureUtil.configureNetwork(strimzi,
116116
composeProjectBuildItem.getDefaultNetworkId(), useSharedNetwork, "kafka");

integration-tests/kafka-devservices/src/test/java/io/quarkus/it/kafka/continuoustesting/DevServicesContainerSharingTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ public class DevServicesContainerSharingTest extends BaseDevServiceTest {
3333

3434
@BeforeAll
3535
static void beforeAll() {
36-
kafka = new StrimziKafkaContainer().withKraft()
37-
.withLabel("quarkus-dev-service-kafka", "kafka");
36+
kafka = new StrimziKafkaContainer().withLabel("quarkus-dev-service-kafka", "kafka");
3837
kafka.start();
3938
}
4039

integration-tests/kafka-oauth-keycloak/src/test/java/io/quarkus/it/kafka/KafkaKeycloakTestResource.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ public Map<String, String> start() {
2828
client.createRealmFromPath(KEYCLOAK_REALM_JSON);
2929

3030
//Start kafka container
31-
this.kafka = new StrimziKafkaContainer("quay.io/strimzi/kafka:latest-kafka-3.7.0")
31+
this.kafka = new StrimziKafkaContainer("quay.io/strimzi/kafka:latest-kafka-4.1.0")
3232
.withBrokerId(1)
3333
.withKafkaConfigurationMap(Map.ofEntries(
34-
entry("listener.security.protocol.map", "JWT:SASL_PLAINTEXT,BROKER1:PLAINTEXT"),
34+
entry("listener.security.protocol.map", "JWT:SASL_PLAINTEXT,BROKER1:PLAINTEXT,CONTROLLER:PLAINTEXT"),
3535
entry("listener.name.jwt.oauthbearer.sasl.jaas.config",
3636
getOauthSaslJaasConfig(keycloak.getInternalUrl(), keycloak.getServerUrl())),
3737
entry("listener.name.jwt.plain.sasl.jaas.config",

integration-tests/kafka-sasl-elytron/src/test/java/io/quarkus/it/kafka/KafkaSaslTestResource.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ public Map<String, String> start() {
3939
.withBootstrapServers(
4040
c -> String.format("SASL_PLAINTEXT://%s:%s", c.getHost(), c.getMappedPort(KAFKA_PORT)))
4141
.withKafkaConfigurationMap(Map.ofEntries(
42-
entry("listener.security.protocol.map", "SASL_PLAINTEXT:SASL_PLAINTEXT,BROKER1:PLAINTEXT"),
42+
entry("listener.security.protocol.map",
43+
"SASL_PLAINTEXT:SASL_PLAINTEXT,BROKER1:PLAINTEXT,CONTROLLER:PLAINTEXT"),
4344
entry("inter.broker.listener.name", "SASL_PLAINTEXT"),
4445
entry("sasl.enabled.mechanisms", "GSSAPI"),
4546
entry("sasl.mechanism.inter.broker.protocol", "GSSAPI"),

integration-tests/kafka-sasl/src/test/java/io/quarkus/it/kafka/KafkaSASLTestResource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public class KafkaSASLTestResource implements QuarkusTestResourceLifecycleManage
1717
c.getMappedPort(KAFKA_PORT)))
1818
.withKafkaConfigurationMap(Map.ofEntries(
1919
entry("listener.security.protocol.map",
20-
"SASL_PLAINTEXT:SASL_PLAINTEXT,BROKER1:PLAINTEXT,PLAINTEXT:PLAINTEXT"),
20+
"SASL_PLAINTEXT:SASL_PLAINTEXT,BROKER1:PLAINTEXT,PLAINTEXT:PLAINTEXT,CONTROLLER:PLAINTEXT"),
2121
entry("sasl.enabled.mechanisms", "PLAIN"),
2222
entry("sasl.mechanism.inter.broker.protocol", "PLAIN"),
2323
entry("listener.name.sasl_plaintext.plain.sasl.jaas.config",

integration-tests/kafka-ssl/src/test/java/io/quarkus/it/kafka/KafkaSSLTestResource.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ public class KafkaSSLTestResource implements QuarkusTestResourceLifecycleManager
2828
entry("ssl.truststore.password", "Z_pkTh9xgZovK4t34cGB2o6afT4zZg0L"),
2929
entry("ssl.truststore.type", "PKCS12"),
3030
entry("ssl.endpoint.identification.algorithm", ""),
31-
entry("listener.security.protocol.map", "BROKER1:PLAINTEXT,PLAINTEXT:PLAINTEXT,SSL:SSL")))
31+
entry("listener.security.protocol.map",
32+
"BROKER1:PLAINTEXT,PLAINTEXT:PLAINTEXT,SSL:SSL,CONTROLLER:PLAINTEXT")))
3233
.withCopyFileToContainer(MountableFile.forHostPath("target/certs/kafka-keystore.p12"),
3334
"/opt/kafka/config/kafka-keystore.p12")
3435
.withCopyFileToContainer(MountableFile.forHostPath("target/certs/kafka-truststore.p12"),

integration-tests/kafka-streams/src/test/java/io/quarkus/it/kafka/streams/KafkaSSLTestResource.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ public class KafkaSSLTestResource implements QuarkusTestResourceLifecycleManager
2424
entry("ssl.truststore.password", "Z_pkTh9xgZovK4t34cGB2o6afT4zZg0L"),
2525
entry("ssl.truststore.type", "PKCS12"),
2626
entry("ssl.endpoint.identification.algorithm=", ""),
27-
entry("listener.security.protocol.map", "BROKER1:PLAINTEXT,PLAINTEXT:PLAINTEXT,SSL:SSL")))
27+
entry("listener.security.protocol.map",
28+
"BROKER1:PLAINTEXT,PLAINTEXT:PLAINTEXT,SSL:SSL,CONTROLLER:PLAINTEXT")))
2829
.withBootstrapServers(c -> String.format("SSL://%s:%s", c.getHost(), c.getMappedPort(KAFKA_PORT)))
2930
.withCopyFileToContainer(MountableFile.forClasspathResource("ks-keystore.p12"),
3031
"/opt/kafka/config/kafka-keystore.p12")

test-framework/kafka-companion/src/main/java/io/quarkus/test/kafka/KafkaCompanionResource.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ public class KafkaCompanionResource implements QuarkusTestResourceLifecycleManag
1515

1616
public static String STRIMZI_KAFKA_IMAGE_KEY = "strimzi.kafka.image";
1717
public static String KAFKA_PORT_KEY = "kafka.port";
18-
public static String KRAFT_KEY = "kraft";
1918

2019
protected String strimziKafkaContainerImage;
2120
protected Integer kafkaPort;
@@ -56,18 +55,15 @@ public void init(Map<String, String> initArgs) {
5655
strimziKafkaContainerImage = initArgs.get(STRIMZI_KAFKA_IMAGE_KEY);
5756
String portString = initArgs.get(KAFKA_PORT_KEY);
5857
kafkaPort = portString == null ? null : Integer.parseInt(portString);
59-
kraft = Boolean.parseBoolean(initArgs.get(KRAFT_KEY));
60-
kafka = createContainer(strimziKafkaContainerImage);
61-
if (kraft) {
62-
kafka.withBrokerId(1).withKraft();
63-
}
58+
kafka = createContainer(strimziKafkaContainerImage)
59+
.withNodeId(1)
60+
.withBrokerId(1);
6461
if (kafkaPort != null) {
6562
kafka.withPort(kafkaPort);
6663
}
6764
Map<String, String> configMap = new HashMap<>(initArgs);
6865
configMap.remove(STRIMZI_KAFKA_IMAGE_KEY);
6966
configMap.remove(KAFKA_PORT_KEY);
70-
configMap.remove(KRAFT_KEY);
7167
kafka.withKafkaConfigurationMap(configMap);
7268
}
7369
}

0 commit comments

Comments
 (0)