Merge pull request #31795 from geoand/cache-polish

Apply small polish to cache code

Author: geoand

docs/src/main/asciidoc/cache.adoc

@@ -539,19 +539,22 @@ Another way to retrieve a `Cache` instance consists in injecting the `io.quarkus
 ----
 package org.acme.cache;
 
-import jakarta.enterprise.context.ApplicationScoped;
 import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 
 import io.quarkus.cache.Cache;
 import io.quarkus.cache.CacheManager;
 
 import java.util.Optional;
 
-@ApplicationScoped
+@Singleton
 public class CacheClearer {
 
-    @Inject
-    CacheManager cacheManager;
+    private final CacheManager cacheManager;
+
+    public CacheClearer(CacheManager cacheManager) {
+        this.cacheManager = cacheManager;
+    }
 
     public void clearCache(String cacheName) {
         Optional<Cache> cache = cacheManager.getCache(cacheName);
@@ -668,21 +671,24 @@ Similarly, the maximum size of a `CaffeineCache` can be changed in real time if
 ----
 package org.acme.cache;
 
-import jakarta.enterprise.context.ApplicationScoped;
 import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 
 import io.quarkus.cache.Cache;
 import io.quarkus.cache.CacheManager;
 import io.quarkus.cache.CaffeineCache;
 
 import java.time.Duration;
-import java.util.Optional;
+import java.util.Optional;import javax.inject.Singleton;
 
-@ApplicationScoped
+@Singleton
 public class CacheConfigManager {
 
-    @Inject
-    CacheManager cacheManager;
+    private final CacheManager cacheManager;
+
+    public CacheConfigManager(CacheManager cacheManager) {
+        this.cacheManager = cacheManager;
+    }
 
     public void setExpireAfterAccess(String cacheName, Duration duration) {
         Optional<Cache> cache = cacheManager.getCache(cacheName);
@@ -928,16 +934,19 @@ public class CachedService {
 ----
 package org.acme.cache;
 
-import jakarta.enterprise.context.ApplicationScoped;
 import jakarta.inject.Inject;
+import jakarta.inject.Singleton;
 
 import io.quarkus.cache.CacheManager;
 
-@ApplicationScoped
+@Singleton
 public class CacheClearer {
 
-    @Inject
-    CacheManager cacheManager;
+    private final CacheManager cacheManager;
+
+    public CacheClearer(CacheManager cacheManager) {
+        this.cacheManager = cacheManager;
+    }
 
     public void clearAllCaches() {
         for (String cacheName : cacheManager.getCacheNames()) {

extensions/cache/runtime/src/main/java/io/quarkus/cache/CacheManager.java

@@ -13,11 +13,14 @@
  * Code example:
  *
  * <pre>
- * {@literal @}ApplicationScoped
+ * {@literal @}Singleton
  * public class CachedService {
  *
- *     {@literal @}Inject
- *     CacheManager cacheManager;
+ *     private final CacheManager cacheManager;
+ *
+ *     public CachedService(CacheManager cacheManager) {
+ *         this.cacheManager = cacheManager;
+ *     }
 
  *     String getExpensiveValue(Object key) {
  *         Cache cache = cacheManager.getCache("my-cache");

extensions/caffeine/deployment/src/main/java/io/quarkus/caffeine/deployment/CaffeineProcessor.java

@@ -42,10 +42,10 @@ void cacheLoaders(CombinedIndexBuildItem combinedIndex, BuildProducer<Reflective
         }
         if (!effectiveImplementorNames.isEmpty()) {
             //Do not force registering any Caffeine classes if we can avoid it: there's a significant chain reaction
-            reflectiveClasses.produce(new ReflectiveClassBuildItem(true, false, CACHE_LOADER_CLASS_NAME));
-            for (String name : effectiveImplementorNames) {
-                reflectiveClasses.produce(new ReflectiveClassBuildItem(true, false, name));
-            }
+            reflectiveClasses.produce(ReflectiveClassBuildItem.builder(CACHE_LOADER_CLASS_NAME).methods(true).build());
+
+            reflectiveClasses.produce(
+                    ReflectiveClassBuildItem.builder(effectiveImplementorNames.toArray(new String[0])).methods(true).build());
         }
     }