Remove AppCDS generation from core and keep the one in Arc

This is done as Arc is pretty much a requirement for all
applications so we can simplify the AppCDS handling

Author: geoand

core/deployment/src/main/java/io/quarkus/deployment/pkg/builditem/AppCDSControlPointBuildItem.java

@@ -61,8 +61,6 @@
 import io.quarkus.deployment.configuration.RunTimeConfigurationGenerator;
 import io.quarkus.deployment.naming.NamingConfig;
 import io.quarkus.deployment.pkg.PackageConfig;
-import io.quarkus.deployment.pkg.builditem.AppCDSControlPointBuildItem;
-import io.quarkus.deployment.pkg.builditem.AppCDSRequestedBuildItem;
 import io.quarkus.deployment.recording.BytecodeRecorderImpl;
 import io.quarkus.dev.appstate.ApplicationStateNotification;
 import io.quarkus.dev.console.QuarkusConsole;
@@ -77,7 +75,6 @@
 import io.quarkus.gizmo.ResultHandle;
 import io.quarkus.gizmo.TryBlock;
 import io.quarkus.runtime.Application;
-import io.quarkus.runtime.ApplicationLifecycleManager;
 import io.quarkus.runtime.ExecutionModeManager;
 import io.quarkus.runtime.LaunchMode;
 import io.quarkus.runtime.NativeImageRuntimePropertiesRecorder;
@@ -87,7 +84,6 @@
 import io.quarkus.runtime.StartupContext;
 import io.quarkus.runtime.StartupTask;
 import io.quarkus.runtime.annotations.QuarkusMain;
-import io.quarkus.runtime.appcds.AppCDSUtil;
 import io.quarkus.runtime.configuration.ConfigUtils;
 import io.quarkus.runtime.util.StepTiming;
 
@@ -140,8 +136,6 @@ void build(List<StaticBytecodeRecorderBuildItem> staticInitTasks,
             LiveReloadBuildItem liveReloadBuildItem,
             ApplicationInfoBuildItem applicationInfo,
             List<AllowJNDIBuildItem> allowJNDIBuildItems,
-            Optional<AppCDSRequestedBuildItem> appCDSRequested,
-            Optional<AppCDSControlPointBuildItem> appCDSControlPoint,
             NamingConfig namingConfig) {
 
         appClassNameProducer.produce(new ApplicationClassNameBuildItem(Application.APP_CLASS_NAME));
@@ -224,22 +218,6 @@ void build(List<StaticBytecodeRecorderBuildItem> staticInitTasks,
         mv = file.getMethodCreator("doStart", void.class, String[].class);
         mv.setModifiers(Modifier.PROTECTED | Modifier.FINAL);
 
-        // if AppCDS generation was requested and no other code has requested handling of the process,
-        // we ensure that the application simply loads some classes from a file and terminates
-        if (appCDSRequested.isPresent() && appCDSControlPoint.isEmpty()) {
-            ResultHandle createAppCDsSysProp = mv.invokeStaticMethod(
-                    ofMethod(System.class, "getProperty", String.class, String.class, String.class),
-                    mv.load(GENERATE_APP_CDS_SYSTEM_PROPERTY), mv.load("false"));
-            ResultHandle createAppCDSBool = mv.invokeStaticMethod(
-                    ofMethod(Boolean.class, "parseBoolean", boolean.class, String.class), createAppCDsSysProp);
-            BytecodeCreator createAppCDS = mv.ifTrue(createAppCDSBool).trueBranch();
-
-            createAppCDS.invokeStaticMethod(ofMethod(AppCDSUtil.class, "loadGeneratedClasses", void.class));
-
-            createAppCDS.invokeStaticMethod(ofMethod(ApplicationLifecycleManager.class, "exit", void.class));
-            createAppCDS.returnValue(null);
-        }
-
         // Make sure we set properties in doStartup as well. This is necessary because setting them in the static-init
         // sets them at build-time, on the host JVM, while SVM has substitutions for System. get/ setProperty at
         // run-time which will never see those properties unless we also set them at run-time.

core/deployment/src/main/java/io/quarkus/deployment/steps/MainClassBuildStep.java

@@ -93,7 +93,6 @@
 import io.quarkus.deployment.builditem.nativeimage.ReflectiveClassBuildItem;
 import io.quarkus.deployment.builditem.nativeimage.ReflectiveFieldBuildItem;
 import io.quarkus.deployment.builditem.nativeimage.ReflectiveMethodBuildItem;
-import io.quarkus.deployment.pkg.builditem.AppCDSControlPointBuildItem;
 import io.quarkus.deployment.pkg.builditem.AppCDSRequestedBuildItem;
 import io.quarkus.runtime.LaunchMode;
 import io.quarkus.runtime.QuarkusApplication;
@@ -641,11 +640,9 @@ public PreBeanContainerBuildItem notifyBeanContainerListeners(ArcContainerBuildI
     @BuildStep
     public void signalBeanContainerReady(AppCDSRecorder recorder, PreBeanContainerBuildItem bi,
             Optional<AppCDSRequestedBuildItem> appCDSRequested,
-            BuildProducer<AppCDSControlPointBuildItem> appCDSControlPointProducer,
             BuildProducer<BeanContainerBuildItem> beanContainerProducer) {
         if (appCDSRequested.isPresent()) {
             recorder.controlGenerationAndExit();
-            appCDSControlPointProducer.produce(new AppCDSControlPointBuildItem());
         }
         beanContainerProducer.produce(new BeanContainerBuildItem(bi.getValue()));
     }