Skip to content

Commit 73d13a8

Browse files
committed
Add comment about ForkJoinClassLoading#setForkJoinClassLoader
1 parent df5b8cf commit 73d13a8

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

core/deployment/src/main/java/io/quarkus/runner/bootstrap/ForkJoinClassLoading.java

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,18 @@ public class ForkJoinClassLoading {
1313
/**
1414
* A yucky hack, basically attempt to make sure every thread in the common pool has
1515
* the correct CL.
16-
*
16+
* <p>
1717
* It's not perfect, but as this only affects test and dev mode and not production it is better
1818
* than nothing.
19-
*
19+
* <p>
2020
* Really we should just not use the common pool at all.
21+
* <p>
22+
* TODO: This no longer works in Java 25 because the `ForkJoinPool` now does
23+
* <a href=
24+
* "https://github.com/openjdk/jdk/blob/jdk-25%2B36/src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java#L2085">
25+
* this</a>, which ends up calling <a href=
26+
* "https://github.com/openjdk/jdk/blob/jdk-25%2B36/src/java.base/share/classes/java/util/concurrent/ForkJoinWorkerThread.java#L280">this</a>.
27+
* We need to figure out how to deal with this
2128
*/
2229
public static void setForkJoinClassLoader(ClassLoader classLoader) {
2330
CountDownLatch allDone = new CountDownLatch(ForkJoinPool.getCommonPoolParallelism());

0 commit comments

Comments
 (0)