Skip to content

Commit 7868c83

Browse files
committed
Fix for missing registry parameters
1 parent c099fb8 commit 7868c83

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

devtools/cli/src/main/java/io/quarkus/cli/image/Push.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ public class Push extends BaseImageCommand {
3737

3838
@Override
3939
public void populateContext(BuildToolContext context) {
40+
super.populateContext(context);
4041
Map<String, String> properties = context.getPropertiesOptions().properties;
4142
registryUsername.ifPresent(u -> properties.put(QUARKUS_CONTAINER_IMAGE_USERNAME, u));
4243

devtools/cli/src/test/java/io/quarkus/cli/image/CliImageGradleTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,10 @@ public void testUsage() throws Exception {
140140
assertTrue(result.getStdout().contains("-Dquarkus.container-image.build=false"));
141141
assertTrue(result.getStdout().contains("--init-script="));
142142

143-
// 4 image push --also-build --dry-run
144-
result = CliDriver.execute(project, "image", "push", "--also-build", "--dry-run");
143+
// 4 image push --also-build --dry-run --registry=quay.io
144+
result = CliDriver.execute(project, "image", "push", "--also-build", "--dry-run", "--registry=quay.io");
145145
assertEquals(CommandLine.ExitCode.OK, result.getExitCode(), "Expected OK return code." + result);
146146
assertTrue(result.getStdout().contains("-Dquarkus.container-image.build=true"));
147+
assertTrue(result.getStdout().contains("-Dquarkus.container-image.registry=quay.io"));
147148
}
148149
}

devtools/cli/src/test/java/io/quarkus/cli/image/CliImageMavenTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,11 @@ public void testUsage() throws Exception {
6969
assertEquals(CommandLine.ExitCode.OK, result.getExitCode(), "Expected OK return code." + result);
7070
assertTrue(result.getStdout().contains("-Dquarkus.container-image.build=false"));
7171

72-
// 4 image push --also-build --dry-run
73-
result = CliDriver.execute(project, "image", "push", "--also-build", "--dry-run");
72+
// 4 image push --also-build --dry-run --registry=quay.io
73+
result = CliDriver.execute(project, "image", "push", "--also-build", "--dry-run", "--registry=quay.io");
7474
assertEquals(CommandLine.ExitCode.OK, result.getExitCode(), "Expected OK return code." + result);
7575
assertTrue(result.getStdout().contains("-Dquarkus.container-image.build=true"));
76+
assertTrue(result.getStdout().contains("-Dquarkus.container-image.registry=quay.io"));
7677

7778
}
7879
}

0 commit comments

Comments
 (0)