Skip to content

Commit 7eeb9dd

Browse files
authored
Merge pull request #44468 from gastaldi/flyway_enabled_k8s
Use `QUARKUS_FLYWAY_ACTIVE` instead of `QUARKUS_FLYWAY_ENABLED` env in Kubernetes resources
2 parents e9a720f + ef97403 commit 7eeb9dd

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

extensions/flyway/deployment/src/main/java/io/quarkus/flyway/deployment/FlywayProcessor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,8 @@ public ServiceStartBuildItem startActions(FlywayRecorder recorder,
298298
public InitTaskBuildItem configureInitTask(ApplicationInfoBuildItem app) {
299299
return InitTaskBuildItem.create()
300300
.withName(app.getName() + "-flyway-init")
301-
.withTaskEnvVars(Map.of("QUARKUS_INIT_AND_EXIT", "true", "QUARKUS_FLYWAY_ENABLED", "true"))
302-
.withAppEnvVars(Map.of("QUARKUS_FLYWAY_ENABLED", "false"))
301+
.withTaskEnvVars(Map.of("QUARKUS_INIT_AND_EXIT", "true", "QUARKUS_FLYWAY_ACTIVE", "true"))
302+
.withAppEnvVars(Map.of("QUARKUS_FLYWAY_ACTIVE", "false"))
303303
.withSharedEnvironment(true)
304304
.withSharedFilesystem(true);
305305
}

integration-tests/kubernetes/quarkus-standard-way/src/test/java/io/quarkus/it/kubernetes/KubernetesWithFlywayInitBase.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,7 @@ public void assertGeneratedResources(Path kubernetesDir, String name, String tas
2929
&& name.equals(d.getMetadata().getName()))
3030
.map(d -> (Deployment) d).findAny();
3131

32-
assertTrue(deployment.isPresent());
33-
assertThat(deployment).satisfies(j -> j.isPresent());
34-
assertThat(deployment.get()).satisfies(d -> {
32+
assertThat(deployment).isPresent().get().satisfies(d -> {
3533
assertThat(d.getMetadata()).satisfies(m -> {
3634
assertThat(m.getName()).isEqualTo(name);
3735
});
@@ -56,9 +54,7 @@ public void assertGeneratedResources(Path kubernetesDir, String name, String tas
5654
.filter(j -> "Job".equals(j.getKind()) && jobName.equals(j.getMetadata().getName()))
5755
.map(j -> (Job) j)
5856
.findAny();
59-
assertTrue(job.isPresent());
60-
61-
assertThat(job.get()).satisfies(j -> {
57+
assertThat(job).isPresent().get().satisfies(j -> {
6258
assertThat(j.getSpec()).satisfies(jobSpec -> {
6359
assertThat(jobSpec.getCompletionMode()).isEqualTo("NonIndexed");
6460
assertThat(jobSpec.getTemplate()).satisfies(t -> {
@@ -69,7 +65,7 @@ public void assertGeneratedResources(Path kubernetesDir, String name, String tas
6965
assertThat(podSpec.getRestartPolicy()).isEqualTo("OnFailure");
7066
assertThat(podSpec.getContainers()).singleElement().satisfies(container -> {
7167
assertThat(container.getName()).isEqualTo(jobName);
72-
assertThat(container.getEnv()).filteredOn(env -> "QUARKUS_FLYWAY_ENABLED".equals(env.getName()))
68+
assertThat(container.getEnv()).filteredOn(env -> "QUARKUS_FLYWAY_ACTIVE".equals(env.getName()))
7369
.singleElement().satisfies(env -> {
7470
assertThat(env.getValue()).isEqualTo("true");
7571
});

0 commit comments

Comments
 (0)