Merge pull request #47248 from gsmet/disable-log-rotation

Allow to disable log rotation

Author: gsmet

core/runtime/src/main/java/io/quarkus/runtime/logging/LogRuntimeConfig.java

@@ -223,6 +223,13 @@ interface FileConfig {
         RotationConfig rotation();
 
         interface RotationConfig {
+
+            /**
+             * Whether log rotation is enabled.
+             */
+            @WithDefault("true")
+            boolean enabled();
+
             /**
              * The maximum log file size, after which a rotation is executed, up to {@code Long.MAX_VALUE} bytes.
              * Note that the file is rotated <em>after</em> the log record is written.

core/runtime/src/main/java/io/quarkus/runtime/logging/LoggingSetupRecorder.java

@@ -654,7 +654,9 @@ private static Handler configureFileHandler(final FileConfig config, final Error
             final boolean includeFilters) {
         FileHandler handler;
         FileConfig.RotationConfig rotationConfig = config.rotation();
-        if (rotationConfig.fileSuffix().isPresent()) {
+        if (!rotationConfig.enabled()) {
+            handler = new FileHandler();
+        } else if (rotationConfig.fileSuffix().isPresent()) {
             PeriodicSizeRotatingFileHandler periodicSizeRotatingFileHandler = new PeriodicSizeRotatingFileHandler();
             periodicSizeRotatingFileHandler.setSuffix(rotationConfig.fileSuffix().get());
             periodicSizeRotatingFileHandler.setRotateSize(rotationConfig.maxFileSize().asLongValue());

integration-tests/test-extension/extension/deployment/src/main/resources/application-no-log-rotation.properties

@@ -0,0 +1,6 @@
+quarkus.log.level=INFO
+quarkus.log.file.enable=true
+quarkus.log.file.level=INFO
+quarkus.log.file.format=%d{HH:mm:ss} %-5p [%c{2.}]] (%t) %s%e%n
+quarkus.log.file.rotation.enabled=false
+quarkus.root.dsa-key-location=/DSAPublicKey.encoded

integration-tests/test-extension/extension/deployment/src/test/java/io/quarkus/logging/NoRotationLoggingTest.java

@@ -0,0 +1,38 @@
+package io.quarkus.logging;
+
+import static io.quarkus.logging.LoggingTestsHelper.getHandler;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.util.logging.Formatter;
+import java.util.logging.Handler;
+import java.util.logging.Level;
+
+import org.jboss.logmanager.formatters.PatternFormatter;
+import org.jboss.logmanager.handlers.FileHandler;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.test.QuarkusUnitTest;
+
+public class NoRotationLoggingTest {
+
+    @RegisterExtension
+    static final QuarkusUnitTest config = new QuarkusUnitTest()
+            .withConfigurationResource("application-no-log-rotation.properties")
+            .withApplicationRoot((jar) -> jar
+                    .addClass(LoggingTestsHelper.class)
+                    .addAsManifestResource("application.properties", "microprofile-config.properties"))
+            .setLogFileName("NoRotationLoggingTest.log");
+
+    @Test
+    public void sizeRotatingConfigurationTest() {
+        Handler handler = getHandler(FileHandler.class);
+        assertThat(handler.getLevel()).isEqualTo(Level.INFO);
+        assertThat(handler).isExactlyInstanceOf(FileHandler.class);
+
+        Formatter formatter = handler.getFormatter();
+        assertThat(formatter).isInstanceOf(PatternFormatter.class);
+        PatternFormatter patternFormatter = (PatternFormatter) formatter;
+        assertThat(patternFormatter.getPattern()).isEqualTo("%d{HH:mm:ss} %-5p [%c{2.}]] (%t) %s%e%n");
+    }
+}