Merge pull request #50760 from Ladicek/redis-client-topology-cache-ttl

Redis Client: add sentinel topology cache TTL configuration

Author: geoand

extensions/redis-client/runtime/src/main/java/io/quarkus/redis/runtime/client/VertxRedisClientFactory.java

@@ -100,7 +100,11 @@ public void accept(Set<URI> uris) {
         options.setPassword(config.password().orElse(null));
         config.poolCleanerInterval().ifPresent(d -> options.setPoolCleanerInterval((int) d.toMillis()));
         config.poolRecycleTimeout().ifPresent(d -> options.setPoolRecycleTimeout((int) d.toMillis()));
-        options.setHashSlotCacheTTL(config.hashSlotCacheTtl().toMillis());
+        // the Vert.x Redis client will only unify `topologyCacheTTL` and `hashSlotCacheTTL` in version 5.1,
+        // but in Quarkus, we unify them already
+        long topologyCacheTtl = config.topologyCacheTtl().orElse(config.hashSlotCacheTtl()).toMillis();
+        options.setHashSlotCacheTTL(topologyCacheTtl);
+        options.setTopologyCacheTTL(topologyCacheTtl);
 
         config.role().ifPresent(options::setRole);
         options.setType(config.clientType());

extensions/redis-client/runtime/src/main/java/io/quarkus/redis/runtime/client/config/RedisClientConfig.java

@@ -148,16 +148,23 @@ public interface RedisClientConfig {
     Optional<ProtocolVersion> preferredProtocolVersion();
 
     /**
-     * The TTL of the hash slot cache. A hash slot cache is used by the clustered Redis client
-     * to prevent constantly sending {@code CLUSTER SLOTS} commands to the first statically
-     * configured cluster node.
-     * <p>
-     * This setting is only meaningful in case of a clustered Redis client and has no effect
-     * otherwise.
+     * @deprecated use {@code quarkus.redis.topology-cache-ttl}
      */
+    @Deprecated(forRemoval = true, since = "3.30")
     @WithDefault("1s")
     Duration hashSlotCacheTtl();
 
+    /**
+     * The TTL of the topology cache. A topology cache is used by a clustered Redis client
+     * and a sentinel Redis client to prevent constantly sending topology discovery commands
+     * ({@code CLUSTER SLOTS} or {@code SENTINEL ...}).
+     * <p>
+     * This setting is only meaningful in case of a clustered Redis client and a sentinel
+     * Redis client and has no effect otherwise.
+     */
+    @WithDefault("1s")
+    Optional<Duration> topologyCacheTtl();
+
     /**
      * Whether automatic failover is enabled. This only makes sense for sentinel clients
      * with role of {@code MASTER} and is ignored otherwise.