Merge pull request #47633 from mkouba/issue-47596

gsmet · web-flow · commit 93191f3e0e45 · 2025-05-05T15:46:34.000+02:00
ArC: optimize the generated dependency graphs for the Dev UI
diff --git a/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ArcDevModeConfig.java b/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/ArcDevModeConfig.java
@@ -15,9 +15,17 @@ public interface ArcDevModeConfig {
     boolean monitoringEnabled();
 
     /**
-     * If set to true then the dependency graphs are generated and available in the Dev UI.
+     * If set to {@code true} then the dependency graphs are generated and available in the Dev UI. If set to {@code auto}
+     * then the dependency graphs are generated if there's less than 1000 beans in the application. If set to {@code false} the
+     * dependency graphs are not generated.
      */
-    @WithDefault("true")
-    boolean generateDependencyGraphs();
+    @WithDefault("auto")
+    GenerateDependencyGraphs generateDependencyGraphs();
+
+    public enum GenerateDependencyGraphs {
+        TRUE,
+        FALSE,
+        AUTO
+    }
 
 }
diff --git a/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/devui/ArcDevModeApiProcessor.java b/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/devui/ArcDevModeApiProcessor.java
@@ -10,6 +10,8 @@
 import java.util.Set;
 import java.util.stream.Collectors;
 
+import org.jboss.logging.Logger;
+
 import io.quarkus.arc.deployment.ArcConfig;
 import io.quarkus.arc.deployment.CompletedApplicationClassPredicateBuildItem;
 import io.quarkus.arc.deployment.ValidationPhaseBuildItem;
@@ -29,6 +31,19 @@
 
 public class ArcDevModeApiProcessor {
 
+    private static final Logger LOG = Logger.getLogger(ArcDevModeApiProcessor.class);
+
+    /**
+     * Do not generate dependency graphs for apps with more than N beans
+     */
+    private static final int DEPENCENY_GRAPH_BEANS_LIMIT = 1000;
+
+    /**
+     * If a dependency graph exceeds the limit then we apply the {@link DevBeanInfos#MAX_DEPENDENCY_LEVEL} and if still exceeds
+     * the limit it's skipped completely, i.e. dependency graph is not available
+     */
+    private static final int DEPENCENY_GRAPH_NODES_LIMIT = 30;
+
     @BuildStep(onlyIf = IsDevelopment.class)
     public void collectBeanInfo(ArcConfig config, ValidationPhaseBuildItem validationPhaseBuildItem,
             CompletedApplicationClassPredicateBuildItem predicate,
@@ -65,7 +80,7 @@ public void collectBeanInfo(ArcConfig config, ValidationPhaseBuildItem validatio
 
         // Build dependency graphs
         Map<String, List<String>> beanDependenciesMap = new HashMap<>();
-        if (config.devMode().generateDependencyGraphs()) {
+        if (generateDependencyGraphs(config, beanInfos)) {
             BeanResolver resolver = validationPhaseBuildItem.getBeanResolver();
             Collection<BeanInfo> beans = validationContext.get(BuildExtension.Key.BEANS);
             Map<BeanInfo, List<InjectionPointInfo>> directDependents = new HashMap<>();
@@ -85,11 +100,27 @@ public void collectBeanInfo(ArcConfig config, ValidationPhaseBuildItem validatio
                 DependencyGraph dependencyGraph = buildDependencyGraph(bean, validationContext, resolver, beanInfos,
                         allInjectionPoints, declaringToProducers,
                         directDependents);
+                if (dependencyGraph.links.isEmpty()) {
+                    // Skip the graph if no links exist
+                    continue;
+                }
+                if (dependencyGraph.nodes.size() > DEPENCENY_GRAPH_NODES_LIMIT) {
+                    DependencyGraph visibleGraph = dependencyGraph.forLevel(DevBeanInfos.DEFAULT_MAX_DEPENDENCY_LEVEL);
+                    if (visibleGraph.nodes.size() > DEPENCENY_GRAPH_NODES_LIMIT) {
+                        LOG.debugf("Skip dependency graph for %s - too many visible nodes: %s", bean,
+                                visibleGraph.nodes.size());
+                        continue;
+                    } else {
+                        LOG.debugf("Dependency graph for %s was reduced to visible nodes: %s", bean,
+                                dependencyGraph.nodes.size());
+                        dependencyGraph = visibleGraph;
+                    }
+                }
                 beanInfos.addDependencyGraph(bean.getIdentifier(), dependencyGraph);
                 // id -> [dep1Id, dep2Id]
                 beanDependenciesMap.put(bean.getIdentifier(),
                         dependencyGraph.filterLinks(link -> link.type.equals("directDependency")).nodes.stream()
-                                .map(DevBeanInfo::getId).filter(id -> !id.equals(bean.getIdentifier()))
+                                .map(Node::getId).filter(id -> !id.equals(bean.getIdentifier()))
                                 .collect(Collectors.toList()));
             }
         }
@@ -111,7 +142,7 @@ DependencyGraph buildDependencyGraph(BeanInfo bean, ValidationContext validation
         addNodesDependencies(0, bean, nodes, links, bean, devBeanInfos);
         addNodesDependents(0, bean, nodes, links, bean, allInjectionPoints, declaringToProducers, resolver, devBeanInfos,
                 directDependents);
-        return new DependencyGraph(nodes, links);
+        return new DependencyGraph(nodes.stream().map(Node::from).collect(Collectors.toSet()), links);
     }
 
     private void addNodesDependencies(int level, BeanInfo root, Set<DevBeanInfo> nodes, Set<Link> links, BeanInfo bean,
@@ -184,4 +215,13 @@ private void addNodesDependents(int level, BeanInfo root, Set<DevBeanInfo> nodes
         }
     }
 
+    private boolean generateDependencyGraphs(ArcConfig config, DevBeanInfos beanInfos) {
+        return switch (config.devMode().generateDependencyGraphs()) {
+            case TRUE -> true;
+            case FALSE -> false;
+            case AUTO -> beanInfos.getBeans().size() < DEPENCENY_GRAPH_BEANS_LIMIT;
+            default -> throw new IllegalArgumentException("Unexpected value: " + config.devMode().generateDependencyGraphs());
+        };
+    }
+
 }
diff --git a/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/devui/DependencyGraph.java b/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/devui/DependencyGraph.java
@@ -8,11 +8,11 @@ public class DependencyGraph {
 
     static final DependencyGraph EMPTY = new DependencyGraph(Set.of(), Set.of());
 
-    public final Set<DevBeanInfo> nodes;
+    public final Set<Node> nodes;
     public final Set<Link> links;
     public final int maxLevel;
 
-    public DependencyGraph(Set<DevBeanInfo> nodes, Set<Link> links) {
+    public DependencyGraph(Set<Node> nodes, Set<Link> links) {
         this.nodes = nodes;
         this.links = links;
         this.maxLevel = links.stream().mapToInt(l -> l.level).max().orElse(0);
@@ -25,7 +25,7 @@ DependencyGraph forLevel(int level) {
     DependencyGraph filterLinks(Predicate<Link> predicate) {
         // Filter out links first
         Set<Link> newLinks = new HashSet<>();
-        Set<DevBeanInfo> newNodes = new HashSet<>();
+        Set<Node> newNodes = new HashSet<>();
         Set<String> usedIds = new HashSet<>();
         for (Link link : links) {
             if (predicate.test(link)) {
@@ -35,7 +35,7 @@ DependencyGraph filterLinks(Predicate<Link> predicate) {
             }
         }
         // Now keep only nodes for which a link exists...
-        for (DevBeanInfo node : nodes) {
+        for (Node node : nodes) {
             if (usedIds.contains(node.getId())) {
                 newNodes.add(node);
             }
diff --git a/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/devui/DevBeanInfos.java b/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/devui/DevBeanInfos.java
@@ -90,6 +90,7 @@ public DevInterceptorInfo getInterceptor(String id) {
     }
 
     public DependencyGraph getDependencyGraph(String beanId) {
+        // Note that MAX_DEPENDENCY_LEVEL is not implemented in UI yet
         Integer maxLevel = DevConsoleManager.getGlobal(MAX_DEPENDENCY_LEVEL);
         if (maxLevel == null) {
             maxLevel = DEFAULT_MAX_DEPENDENCY_LEVEL;
diff --git a/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/devui/Node.java b/extensions/arc/deployment/src/main/java/io/quarkus/arc/deployment/devui/Node.java
@@ -0,0 +1,31 @@
+package io.quarkus.arc.deployment.devui;
+
+public class Node {
+
+    static Node from(DevBeanInfo beanInfo) {
+        return new Node(beanInfo.getId(), beanInfo.getDescription(), beanInfo.getSimpleDescription());
+    }
+
+    private final String id;
+    private final String description;
+    private final String simpleDescription;
+
+    Node(String id, String description, String simpleDescription) {
+        this.id = id;
+        this.description = description;
+        this.simpleDescription = simpleDescription;
+    }
+
+    public String getId() {
+        return id;
+    }
+
+    public String getDescription() {
+        return description;
+    }
+
+    public String getSimpleDescription() {
+        return simpleDescription;
+    }
+
+}
diff --git a/extensions/arc/deployment/src/main/resources/dev-ui/qwc-arc-bean-graph.js b/extensions/arc/deployment/src/main/resources/dev-ui/qwc-arc-bean-graph.js
@@ -92,7 +92,6 @@ export class QwcArcBeanGraph extends LitElement {
             }else {
                 newNode.category = catindex;
             }
-            //console.log('Adding node: ' + newNode.name);
             return this._nodes.push(newNode) - 1;
         }
         return index;

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ public DevInterceptorInfo getInterceptor(String id) {`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`public DependencyGraph getDependencyGraph(String beanId) {`
	`93`	`+ // Note that MAX_DEPENDENCY_LEVEL is not implemented in UI yet`
`93`	`94`	`Integer maxLevel = DevConsoleManager.getGlobal(MAX_DEPENDENCY_LEVEL);`
`94`	`95`	`if (maxLevel == null) {`
`95`	`96`	`maxLevel = DEFAULT_MAX_DEPENDENCY_LEVEL;`
Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,6 @@ export class QwcArcBeanGraph extends LitElement {`
`92`	`92`	`}else {`
`93`	`93`	`newNode.category = catindex;`
`94`	`94`	`}`
`95`		`- //console.log('Adding node: ' + newNode.name);`
`96`	`95`	`return this._nodes.push(newNode) - 1;`
`97`	`96`	`}`
`98`	`97`	`return index;`