Rename AddJobResourceDecorator2 to CreateJobResourceFromImageDecorator

The AddJobResourceDecorator and AddJobResourceDecorator2 classes are meant to fulfill different purposes, so it makes more sense to rename AddJobResourceDecorator2 to CreateJobResourceFromImageDecorator.

Fix #31723

Author: Sgitario

extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/AddJobResourceDecorator2.java

@@ -14,6 +14,7 @@ public final class Constants {
     public static final String INGRESS = "Ingress";
     public static final String BATCH_GROUP = "batch";
     public static final String BATCH_VERSION = "v1";
+    public static final String JOB_API_VERSION = BATCH_GROUP + "/" + BATCH_VERSION;
 
     static final String DOCKER = "docker";
 

extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/Constants.java

@@ -0,0 +1,57 @@
+
+package io.quarkus.kubernetes.deployment;
+
+import static io.quarkus.kubernetes.deployment.Constants.JOB;
+import static io.quarkus.kubernetes.deployment.Constants.JOB_API_VERSION;
+
+import java.util.List;
+
+import io.dekorate.kubernetes.decorator.ResourceProvidingDecorator;
+import io.fabric8.kubernetes.api.model.KubernetesListBuilder;
+import io.fabric8.kubernetes.api.model.batch.v1.JobBuilder;
+
+/**
+ * Create a new Job resource using an image, the command, and arguments.
+ **/
+public class CreateJobResourceFromImageDecorator extends ResourceProvidingDecorator<KubernetesListBuilder> {
+
+    private static final String DEFAULT_RESTART_POLICY = "OnFailure";
+    private static final String DEFAULT_COMPLETION_MODE = "OnFailure";
+
+    private final String name;
+    private final String image;
+    private final List<String> command;
+    private final List<String> arguments;
+
+    public CreateJobResourceFromImageDecorator(String name, String image, List<String> command, List<String> arguments) {
+        this.name = name;
+        this.image = image;
+        this.command = command;
+        this.arguments = arguments;
+    }
+
+    @Override
+    public void visit(KubernetesListBuilder list) {
+        if (!contains(list, JOB_API_VERSION, JOB, name)) {
+            list.addToItems(new JobBuilder()
+                    .withNewMetadata()
+                    .withName(name)
+                    .endMetadata()
+                    .withNewSpec()
+                    .withCompletionMode(DEFAULT_COMPLETION_MODE)
+                    .withNewTemplate()
+                    .withNewSpec()
+                    .withRestartPolicy(DEFAULT_RESTART_POLICY)
+                    .addNewContainer()
+                    .withName(name)
+                    .withImage(image)
+                    .withCommand(command)
+                    .withArgs(arguments)
+                    .endContainer()
+                    .endSpec()
+                    .endTemplate()
+                    .endSpec()
+                    .build());
+        }
+    }
+}

extensions/kubernetes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/CreateJobResourceFromImageDecorator.java

@@ -467,8 +467,10 @@ public void andThenVisit(ContainerBuilder builder, ObjectMeta meta) {
                 }
 
             }
+
             result.add(new DecoratorBuildItem(target,
-                    new AddJobResourceDecorator2(item.getName(), item.getImage(), item.getCommand(), item.getArguments())));
+                    new CreateJobResourceFromImageDecorator(item.getName(), item.getImage(), item.getCommand(),
+                            item.getArguments())));
         });
         return result;
     }