Merge pull request #48201 from gsmet/build-optimizations

Micro build optimizations for ArC

Author: gsmet

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanDeployment.java

@@ -89,6 +89,7 @@ public class BeanDeployment {
     private final List<DecoratorInfo> decorators;
 
     private final List<ObserverInfo> observers;
+    private Set<MethodInfo> observerAndProducerMethods;
 
     private final Set<InvokerInfo> invokers;
 
@@ -317,6 +318,8 @@ void init(Consumer<BytecodeTransformer> bytecodeTransformerConsumer,
             List<Predicate<BeanInfo>> additionalUnusedBeanExclusions) {
         long start = System.nanoTime();
 
+        initObserverAndProducerMethods(observers, beans);
+
         // Collect dependency resolution errors
         List<Throwable> errors = new ArrayList<>();
         for (BeanInfo bean : beans) {
@@ -789,6 +792,15 @@ Integer computeAlternativePriority(AnnotationTarget target, List<StereotypeInfo>
     }
 
     Set<MethodInfo> getObserverAndProducerMethods() {
+        if (observerAndProducerMethods == null) {
+            throw new IllegalStateException(
+                    "getObserverAndProducerMethods() has been called but observerAndProducerMethods has not been initialized yet");
+        }
+
+        return observerAndProducerMethods;
+    }
+
+    private void initObserverAndProducerMethods(List<ObserverInfo> observers, List<BeanInfo> beans) {
         Set<MethodInfo> ret = new HashSet<>();
         for (ObserverInfo observer : observers) {
             if (!observer.isSynthetic()) {
@@ -800,7 +812,8 @@ Set<MethodInfo> getObserverAndProducerMethods() {
                 ret.add(bean.getTarget().get().asMethod());
             }
         }
-        return ret;
+
+        observerAndProducerMethods = Collections.unmodifiableSet(ret);
     }
 
     private boolean isRuntimeAnnotationType(ClassInfo annotationType) {

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Methods.java

@@ -337,15 +337,27 @@ static class MethodKey {
         final List<DotName> params;
         final DotName returnType;
         final MethodInfo method; // this is intentionally ignored for equals/hashCode
+        private final int hashCode;
 
         public MethodKey(MethodInfo method) {
             this.method = Objects.requireNonNull(method, "Method must not be null");
             this.name = method.name();
             this.returnType = method.returnType().name();
-            this.params = new ArrayList<>();
-            for (Type i : method.parameterTypes()) {
-                params.add(i.name());
-            }
+            this.params = switch (method.parametersCount()) {
+                case 0 -> List.of();
+                case 1 -> List.of(method.parameterTypes().get(0).name());
+                case 2 -> List.of(method.parameterTypes().get(0).name(), method.parameterTypes().get(1).name());
+                default -> {
+                    List<DotName> ret = new ArrayList<>(method.parametersCount());
+                    for (Type parameterType : method.parameterTypes()) {
+                        ret.add(parameterType.name());
+                    }
+                    yield ret;
+                }
+            };
+
+            // the Map can be resized several times so it's worth caching the hashCode
+            this.hashCode = buildHashCode(this.name, this.params, this.returnType);
         }
 
         @Override
@@ -362,7 +374,14 @@ public boolean equals(Object o) {
 
         @Override
         public int hashCode() {
-            return Objects.hash(name, params, returnType);
+            return hashCode;
+        }
+
+        private static int buildHashCode(String name, List<DotName> params, DotName returnType) {
+            int result = Objects.hashCode(name);
+            result = 31 * result + Objects.hashCode(params);
+            result = 31 * result + Objects.hashCode(returnType);
+            return result;
         }
     }