Merge pull request #31718 from geoand/#31713

geoand · web-flow · commit bbb56f92d755 · 2023-03-09T16:41:02.000+02:00
Properly close metadata file in integration tests
diff --git a/test-framework/junit5/src/main/java/io/quarkus/test/junit/IntegrationTestUtil.java b/test-framework/junit5/src/main/java/io/quarkus/test/junit/IntegrationTestUtil.java
@@ -433,9 +433,10 @@ static Properties readQuarkusArtifactProperties(ExtensionContext context) {
             }
             throw new IllegalStateException(errorMessage);
         }
-        try {
-            Properties properties = new Properties();
-            properties.load(new FileInputStream(artifactProperties.toFile()));
+
+        Properties properties = new Properties();
+        try (var fis = new FileInputStream(artifactProperties.toFile())) {
+            properties.load(fis);
             return properties;
         } catch (IOException e) {
             throw new UncheckedIOException(

Original file line number	Diff line number	Diff line change
`@@ -433,9 +433,10 @@ static Properties readQuarkusArtifactProperties(ExtensionContext context) {`
`433`	`433`	`}`
`434`	`434`	`throw new IllegalStateException(errorMessage);`
`435`	`435`	`}`
`436`		`- try {`
`437`		`- Properties properties = new Properties();`
`438`		`- properties.load(new FileInputStream(artifactProperties.toFile()));`
	`436`	`+`
	`437`	`+ Properties properties = new Properties();`
	`438`	`+ try (var fis = new FileInputStream(artifactProperties.toFile())) {`
	`439`	`+ properties.load(fis);`
`439`	`440`	`return properties;`
`440`	`441`	`} catch (IOException e) {`
`441`	`442`	`throw new UncheckedIOException(`