Skip to content

Commit bd0b5e1

Browse files
committed
Add HTTP response to HttpClientMetricsTagsContributor.Context
1 parent 9ac63d5 commit bd0b5e1

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

extensions/micrometer/runtime/src/main/java/io/quarkus/micrometer/runtime/HttpClientMetricsTagsContributor.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import io.micrometer.core.instrument.Tags;
44
import io.micrometer.core.instrument.config.MeterFilter;
55
import io.vertx.core.spi.observability.HttpRequest;
6+
import io.vertx.core.spi.observability.HttpResponse;
67

78
/**
89
* Allows code to add additional Micrometer {@link Tags} to the metrics collected for completed HTTP client requests.
@@ -20,5 +21,7 @@ public interface HttpClientMetricsTagsContributor {
2021

2122
interface Context {
2223
HttpRequest request();
24+
25+
HttpResponse response();
2326
}
2427
}

extensions/micrometer/runtime/src/main/java/io/quarkus/micrometer/runtime/binder/vertx/VertxHttpClientMetrics.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ public void responseEnd(RequestTracker tracker, long bytesRead) {
172172
.and(HttpCommonTags.status(tracker.response.statusCode()))
173173
.and(HttpCommonTags.outcome(tracker.response.statusCode()));
174174
if (!httpClientMetricsTagsContributors.isEmpty()) {
175-
HttpClientMetricsTagsContributor.Context context = new DefaultContext(tracker.request);
175+
HttpClientMetricsTagsContributor.Context context = new DefaultContext(tracker.request, tracker.response);
176176
for (int i = 0; i < httpClientMetricsTagsContributors.size(); i++) {
177177
try {
178178
Tags additionalTags = httpClientMetricsTagsContributors.get(i).contribute(context);
@@ -254,6 +254,7 @@ public String getNormalizedUriPath(Map<Pattern, String> serverMatchPatterns, Lis
254254
}
255255
}
256256

257-
private record DefaultContext(HttpRequest request) implements HttpClientMetricsTagsContributor.Context {
257+
private record DefaultContext(HttpRequest request,
258+
HttpResponse response) implements HttpClientMetricsTagsContributor.Context {
258259
}
259260
}

0 commit comments

Comments
 (0)