Skip to content

Commit be3edfa

Browse files
committed
Pass ApplicationModel to build configuration
1 parent 17d805a commit be3edfa

File tree

9 files changed

+18
-17
lines changed

9 files changed

+18
-17
lines changed

devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/extension/QuarkusPluginExtension.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public void beforeTest(Test task) {
7474
Map<String, Object> props = task.getSystemProperties();
7575
ApplicationModel appModel = getApplicationModel(TEST);
7676

77-
SmallRyeConfig config = buildEffectiveConfiguration(appModel.getAppArtifact(), appModel.getPlatformProperties())
77+
SmallRyeConfig config = buildEffectiveConfiguration(appModel)
7878
.getConfig();
7979
config.getOptionalValue(TEST.getProfileKey(), String.class)
8080
.ifPresent(value -> props.put(TEST.getProfileKey(), value));

devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/AbstractQuarkusExtension.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.gradle.api.tasks.SourceSet;
2828
import org.gradle.process.JavaForkOptions;
2929

30+
import io.quarkus.bootstrap.model.ApplicationModel;
3031
import io.quarkus.gradle.dsl.Manifest;
3132
import io.quarkus.maven.dependency.ResolvedDependency;
3233
import io.smallrye.common.expression.Expression;
@@ -117,8 +118,9 @@ protected Manifest manifest() {
117118
return baseConfig().manifest();
118119
}
119120

120-
protected EffectiveConfig buildEffectiveConfiguration(ResolvedDependency appArtifact,
121-
Map<String, String> platformProperties) {
121+
protected EffectiveConfig buildEffectiveConfiguration(ApplicationModel appModel) {
122+
ResolvedDependency appArtifact = appModel.getAppArtifact();
123+
122124
Map<String, Object> properties = new HashMap<>();
123125
exportCustomManifestProperties(properties);
124126

@@ -141,7 +143,7 @@ protected EffectiveConfig buildEffectiveConfiguration(ResolvedDependency appArti
141143
defaultProperties.putIfAbsent("quarkus.application.version", appArtifact.getVersion());
142144

143145
return EffectiveConfig.builder()
144-
.withPlatformProperties(platformProperties)
146+
.withPlatformProperties(appModel.getPlatformProperties())
145147
.withForcedProperties(forcedPropertiesProperty.get())
146148
.withTaskProperties(properties)
147149
.withBuildProperties(quarkusBuildProperties.get())

devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/Deploy.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,7 @@ public Deploy() {
9191
public void checkRequiredExtensions() {
9292
ApplicationModel appModel = resolveAppModelForBuild();
9393
Properties sysProps = new Properties();
94-
sysProps.putAll(extension().buildEffectiveConfiguration(appModel.getAppArtifact(), appModel.getPlatformProperties())
95-
.getValues());
94+
sysProps.putAll(extension().buildEffectiveConfiguration(appModel).getValues());
9695
try (CuratedApplication curatedApplication = QuarkusBootstrap.builder()
9796
.setBaseClassLoader(getClass().getClassLoader())
9897
.setExistingModel(appModel)

devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusBuildDependencies.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ private void jarDependencies(Path libBoot, Path libMain) {
145145

146146
ApplicationModel appModel = resolveAppModelForBuild();
147147
SmallRyeConfig config = getExtensionView()
148-
.buildEffectiveConfiguration(appModel.getAppArtifact(), appModel.getPlatformProperties(), new HashMap<>())
148+
.buildEffectiveConfiguration(appModel, new HashMap<>())
149149
.getConfig();
150150

151151
// see https://quarkus.io/guides/class-loading-reference#configuring-class-loading

devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusBuildTask.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,8 +244,7 @@ void generateBuild() {
244244

245245
ApplicationModel appModel = resolveAppModelForBuild();
246246
SmallRyeConfig config = getExtensionView()
247-
.buildEffectiveConfiguration(appModel.getAppArtifact(), appModel.getPlatformProperties(),
248-
getAdditionalForcedProperties().get().getProperties())
247+
.buildEffectiveConfiguration(appModel, getAdditionalForcedProperties().get().getProperties())
249248
.getConfig();
250249
Map<String, String> quarkusProperties = Expressions.withoutExpansion(() -> {
251250
Map<String, String> values = new HashMap<>();

devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusGenerateCode.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,7 @@ public Set<File> getInputDirectory() {
119119
public void generateCode() throws IOException {
120120
ApplicationModel appModel = ToolingUtils.deserializeAppModel(getApplicationModel().get().getAsFile().toPath());
121121
Map<String, String> configMap = getExtensionView()
122-
.buildEffectiveConfiguration(appModel.getAppArtifact(), appModel.getPlatformProperties(), new HashMap<>())
123-
.getValues();
122+
.buildEffectiveConfiguration(appModel, new HashMap<>()).getValues();
124123

125124
File outputPath = getGeneratedOutputDirectory().get().getAsFile();
126125

devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusPluginExtensionView.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
import org.gradle.process.JavaForkOptions;
3939
import org.gradle.util.GradleVersion;
4040

41+
import io.quarkus.bootstrap.model.ApplicationModel;
4142
import io.quarkus.deployment.pkg.PackageConfig;
4243
import io.quarkus.gradle.QuarkusPlugin;
4344
import io.quarkus.gradle.dsl.Manifest;
@@ -209,8 +210,10 @@ private void exportCustomManifestProperties(Map<String, Object> properties) {
209210
}
210211
}
211212

212-
protected EffectiveConfig buildEffectiveConfiguration(ResolvedDependency appArtifact,
213-
Map<String, String> platformProperties, Map<String, ?> additionalForcedProperties) {
213+
protected EffectiveConfig buildEffectiveConfiguration(ApplicationModel appModel,
214+
Map<String, ?> additionalForcedProperties) {
215+
ResolvedDependency appArtifact = appModel.getAppArtifact();
216+
214217
Map<String, Object> properties = new HashMap<>();
215218
exportCustomManifestProperties(properties);
216219

@@ -235,7 +238,7 @@ protected EffectiveConfig buildEffectiveConfiguration(ResolvedDependency appArti
235238
forced.put("quarkus.native.enabled", "true");
236239
}
237240
return EffectiveConfig.builder()
238-
.withPlatformProperties(platformProperties)
241+
.withPlatformProperties(appModel.getPlatformProperties())
239242
.withForcedProperties(forced)
240243
.withTaskProperties(properties)
241244
.withBuildProperties(getQuarkusBuildProperties().get())

devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusRun.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,7 @@ public void setJvmArgs(List<String> jvmArgs) {
102102
public void runQuarkus() {
103103
ApplicationModel appModel = resolveAppModelForBuild();
104104
Properties sysProps = new Properties();
105-
sysProps.putAll(extension().buildEffectiveConfiguration(appModel.getAppArtifact(), appModel.getPlatformProperties())
106-
.getValues());
105+
sysProps.putAll(extension().buildEffectiveConfiguration(appModel).getValues());
107106
try (CuratedApplication curatedApplication = QuarkusBootstrap.builder()
108107
.setBaseClassLoader(getClass().getClassLoader())
109108
.setExistingModel(appModel)

devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusShowEffectiveConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public void dumpEffectiveConfiguration() {
4949
try {
5050
ApplicationModel appModel = resolveAppModelForBuild();
5151
EffectiveConfig effectiveConfig = getExtensionView()
52-
.buildEffectiveConfiguration(appModel.getAppArtifact(), appModel.getPlatformProperties(),
52+
.buildEffectiveConfiguration(appModel,
5353
getAdditionalForcedProperties().get().getProperties());
5454
SmallRyeConfig config = effectiveConfig.getConfig();
5555
List<String> sourceNames = new ArrayList<>();

0 commit comments

Comments
 (0)