Added de.thetaphi.forbiddenapis plugin to ArC.

Author: eniuane

independent-projects/arc/processor/banned-signatures.txt

@@ -0,0 +1,8 @@
+@defaultMessage Don't use Maven classes. They won't be available when using Gradle.
+org.apache.maven.**
+org.codehaus.plexus.**
+
+@defaultMessage Never use Type#toString() as it's almost always the wrong thing to do. Usually org.jboss.jandex.DotName#toString() is what is needed
+org.jboss.jandex.Type#toString()
+
+org.apache.commons.io.** @ Don't use commons-io dependency

independent-projects/arc/processor/pom.xml

@@ -63,5 +63,27 @@
         </dependency>
 
     </dependencies>
-
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>de.thetaphi</groupId>
+                <artifactId>forbiddenapis</artifactId>
+                <executions>
+                    <execution>
+                        <id>verify-forbidden-apis</id>
+                        <configuration>
+                            <signaturesFiles>
+                                <signaturesFile>./banned-signatures.txt</signaturesFile>
+                            </signaturesFiles>
+                            <ignoreSignaturesOfMissingClasses>true</ignoreSignaturesOfMissingClasses>
+                        </configuration>
+                        <phase>compile</phase>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+        </plugins>
+    </build>
 </project>

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/ComponentsProviderGenerator.java

@@ -567,7 +567,7 @@ void addComponentInternal(BeanInfo removedBean) {
                 CatchBlockCreator catchBlock = tryBlock.addCatch(Throwable.class);
                 catchBlock.invokeStaticInterfaceMethod(
                         MethodDescriptors.COMPONENTS_PROVIDER_UNABLE_TO_LOAD_REMOVED_BEAN_TYPE,
-                        catchBlock.load(type.toString()), catchBlock.getCaughtException());
+                        catchBlock.load(type.name().toString()), catchBlock.getCaughtException());
                 AssignableResultHandle typeHandle = tryBlock.createVariable(Object.class);
                 try {
                     Types.getTypeHandle(typeHandle, tryBlock, type, tccl, typeCache);
@@ -655,12 +655,12 @@ public void initialize(MethodCreator method) {
 
         @Override
         public ResultHandle get(org.jboss.jandex.Type type, BytecodeCreator bytecode) {
-            return bytecode.invokeInterfaceMethod(MethodDescriptors.MAP_GET, mapHandle, bytecode.load(type.toString()));
+            return bytecode.invokeInterfaceMethod(MethodDescriptors.MAP_GET, mapHandle, bytecode.load(type.name().toString()));
         }
 
         @Override
         public void put(org.jboss.jandex.Type type, ResultHandle value, BytecodeCreator bytecode) {
-            bytecode.invokeInterfaceMethod(MethodDescriptors.MAP_PUT, mapHandle, bytecode.load(type.toString()), value);
+            bytecode.invokeInterfaceMethod(MethodDescriptors.MAP_PUT, mapHandle, bytecode.load(type.name().toString()), value);
         }
 
     }

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/InvokerGenerator.java

@@ -797,7 +797,7 @@ CandidateMethod resolve() {
             }
 
             if (matching.isEmpty()) {
-                String expectedType = this.expectedType.toString();
+                String expectedType = this.expectedType.name().toString();
                 String expectation = "";
                 if (transformer.isInputTransformer()) {
                     expectation = "\n"

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/ObserverGenerator.java

@@ -117,7 +117,7 @@ void precomputeGeneratedName(ObserverInfo observer) {
             if (observer.getId() != null) {
                 sigBuilder.append(observer.getId());
             }
-            sigBuilder.append(observer.getObservedType().toString()).append(observer.getQualifiers().toString())
+            sigBuilder.append(observer.getObservedType().name().toString()).append(observer.getQualifiers().toString())
                     .append(observer.isAsync()).append(observer.getPriority()).append(observer.getTransactionPhase());
         } else {
             sigBuilder.append(observer.getObserverMethod().name())

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/SubclassGenerator.java

@@ -714,7 +714,7 @@ private void processDecorator(DecoratorInfo decorator, BeanInfo bean, Type provi
             MethodCreator forward = delegateSubclass.getMethodCreator(methodDescriptor);
             // Exceptions
             for (Type exception : method.exceptions()) {
-                forward.addException(exception.toString());
+                forward.addException(exception.name().toString());
             }
 
             ResultHandle ret = null;

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/bcextensions/TypeImpl.java

@@ -109,6 +109,6 @@ public Collection<AnnotationInfo> annotations() {
 
     @Override
     public String toString() {
-        return jandexType.toString();
+        return jandexType.name().toString();
     }
 }