Merge pull request #41621 from holly-cummins/remove-cloning-config

Remove deprecated cloning pattern config which isn't really useful anymore

Author: geoand

core/deployment/src/main/java/io/quarkus/deployment/dev/testing/TestConfig.java

@@ -221,17 +221,6 @@ public interface TestConfig {
     @WithDefault("all")
     TestType type();
 
-    /**
-     * If a class matches this pattern then it will be cloned into the Quarkus ClassLoader even if it
-     * is in a parent first artifact.
-     * <p>
-     * This is important for collections which can contain objects from the Quarkus ClassLoader, but for
-     * most parent first classes it will just cause problems.
-     */
-    @WithDefault("java\\..*")
-    @Deprecated(forRemoval = true)
-    String classClonePattern();
-
     /**
      * If this is true then only the tests from the main application module will be run (i.e. the module that is currently
      * running mvn quarkus:dev).

integration-tests/main/src/test/java/io/quarkus/it/main/ParameterResolverTest.java

@@ -45,7 +45,7 @@ public void testSerializableParameterResolver(SomeSerializable someSerializable)
 
     @Test
     @ExtendWith(ParameterResolverTest.ListWithNonSerializableParameterResolver.class)
-    public void testSerializableParameterResolverFallbackToXStream(List<NonSerializable> list) {
+    public void testSerializableParameterResolverFallback(List<NonSerializable> list) {
         assertEquals("foo", list.get(0).value);
         assertEquals("bar", list.get(1).value);
     }

test-framework/junit5/src/main/java/io/quarkus/test/junit/internal/NewSerializingDeepClone.java

@@ -5,7 +5,6 @@
 import java.io.UncheckedIOException;
 import java.lang.reflect.Method;
 import java.util.function.Supplier;
-import java.util.regex.Pattern;
 
 import org.jboss.marshalling.cloner.ClassCloner;
 import org.jboss.marshalling.cloner.ClonerConfiguration;
@@ -20,7 +19,6 @@
  */
 public final class NewSerializingDeepClone implements DeepClone {
     private final ObjectCloner cloner;
-    private static Pattern clonePattern;
     private RunningQuarkusApplication runningQuarkusApplication;
 
     public NewSerializingDeepClone(final ClassLoader sourceLoader, final ClassLoader targetLoader) {
@@ -56,7 +54,7 @@ public Class<?> cloneProxy(final Class<?> proxyClass) {
                     Class<?> theClassWeCareAbout = original.getClass();
 
                     // Short-circuit the checks if we've been configured to clone this
-                    if (!clonePattern.matcher(theClassWeCareAbout.getName()).matches()) {
+                    if (!theClassWeCareAbout.getName().startsWith("java.")) {
 
                         if (theClassWeCareAbout.isPrimitive()) {
                             // avoid copying things that do not need to be copied
@@ -140,9 +138,6 @@ public Object clone(final Object objectToClone) {
     @Override
     public void setRunningQuarkusApplication(RunningQuarkusApplication runningQuarkusApplication) {
         this.runningQuarkusApplication = runningQuarkusApplication;
-        String patternString = runningQuarkusApplication.getConfigValue("quarkus.test.class-clone-pattern", String.class)
-                .orElse("java\\..*");
-        clonePattern = Pattern.compile(patternString);
     }
 
 }