Merge pull request #50049 from joonseolee/feature/mod-prepared-statement-value

Make cachePreparedStatements Optional<Boolean> with database-specific defaults

Author: gsmet

extensions/reactive-datasource/runtime/src/main/java/io/quarkus/reactive/datasource/runtime/DataSourceReactiveRuntimeConfig.java

@@ -23,8 +23,8 @@ public interface DataSourceReactiveRuntimeConfig {
     /**
      * Whether prepared statements should be cached on the client side.
      */
-    @WithDefault("false")
-    boolean cachePreparedStatements();
+    @ConfigDocDefault("true for PostgreSQL/MySQL/MariaDB/Db2, false otherwise")
+    Optional<Boolean> cachePreparedStatements();
 
     /**
      * The datasource URLs.

extensions/reactive-db2-client/runtime/src/main/java/io/quarkus/reactive/db2/client/runtime/DB2PoolRecorder.java

@@ -49,6 +49,8 @@
 @Recorder
 public class DB2PoolRecorder {
 
+    private static final boolean SUPPORTS_CACHE_PREPARED_STATEMENTS = true;
+
     private static final Logger log = Logger.getLogger(DB2PoolRecorder.class);
     private static final TypeLiteral<Instance<DB2PoolCreator>> POOL_CREATOR_TYPE_LITERAL = new TypeLiteral<>() {
     };
@@ -221,7 +223,8 @@ private DB2ConnectOptions toConnectOptions(String dataSourceName, DataSourceRunt
             }
         }
 
-        connectOptions.setCachePreparedStatements(dataSourceReactiveRuntimeConfig.cachePreparedStatements());
+        connectOptions.setCachePreparedStatements(
+                dataSourceReactiveRuntimeConfig.cachePreparedStatements().orElse(SUPPORTS_CACHE_PREPARED_STATEMENTS));
 
         connectOptions.setSsl(dataSourceReactiveDB2Config.ssl());
 

extensions/reactive-mysql-client/runtime/src/main/java/io/quarkus/reactive/mysql/client/runtime/MySQLPoolRecorder.java

@@ -50,6 +50,8 @@
 @Recorder
 public class MySQLPoolRecorder {
 
+    private static final boolean SUPPORTS_CACHE_PREPARED_STATEMENTS = true;
+
     private static final TypeLiteral<Instance<MySQLPoolCreator>> POOL_CREATOR_TYPE_LITERAL = new TypeLiteral<>() {
     };
 
@@ -224,7 +226,9 @@ private List<MySQLConnectOptions> toMySQLConnectOptions(String dataSourceName,
                 }
             }
 
-            mysqlConnectOptions.setCachePreparedStatements(dataSourceReactiveRuntimeConfig.cachePreparedStatements());
+            mysqlConnectOptions
+                    .setCachePreparedStatements(dataSourceReactiveRuntimeConfig.cachePreparedStatements()
+                            .orElse(SUPPORTS_CACHE_PREPARED_STATEMENTS));
 
             dataSourceReactiveMySQLConfig.charset().ifPresent(mysqlConnectOptions::setCharset);
             dataSourceReactiveMySQLConfig.collation().ifPresent(mysqlConnectOptions::setCollation);

extensions/reactive-pg-client/runtime/src/main/java/io/quarkus/reactive/pg/client/runtime/PgPoolRecorder.java

@@ -49,6 +49,8 @@
 @Recorder
 public class PgPoolRecorder {
 
+    private static final boolean SUPPORTS_CACHE_PREPARED_STATEMENTS = true;
+
     private static final TypeLiteral<Instance<PgPoolCreator>> PG_POOL_CREATOR_TYPE_LITERAL = new TypeLiteral<>() {
     };
 
@@ -215,7 +217,8 @@ private List<PgConnectOptions> toPgConnectOptions(String dataSourceName, DataSou
                 }
             }
 
-            pgConnectOptions.setCachePreparedStatements(dataSourceReactiveRuntimeConfig.cachePreparedStatements());
+            pgConnectOptions.setCachePreparedStatements(
+                    dataSourceReactiveRuntimeConfig.cachePreparedStatements().orElse(SUPPORTS_CACHE_PREPARED_STATEMENTS));
 
             if (dataSourceReactivePostgreSQLConfig.pipeliningLimit().isPresent()) {
                 pgConnectOptions.setPipeliningLimit(dataSourceReactivePostgreSQLConfig.pipeliningLimit().getAsInt());