"JDBC resources leaked" when using non-reactive datasources & Kotlin

[jehrenzweig-leagueapps]

I have the following repository method that is being called by a Quarkus endpoint:

import io.agroal.api.AgroalDataSource
import io.quarkus.agroal.DataSource

@ApplicationScoped
class PotatoTypesJdbcReadRepository(
	@DataSource("test") private val testDataSource: AgroalDataSource
) : IPotatoTypesReadRepository {
	override fun getAllPotatoTypes(): List<PotatoTypeEntity> {
		// Return a list of all potato types.
		val potatoTypeEntities: MutableList<PotatoTypeEntity> = mutableListOf()

		this.testDataSource.connection.use { dbConnection ->
			val sqlQuery = "select * from PotatoTypes order by NAME"
			val preparedStatement = dbConnection.prepareStatement(sqlQuery)
			val sqlResult = preparedStatement.executeQuery()

			while (sqlResult.next()) {
				val potatoTypeEntity = PotatoTypeEntityJdbcRowMapper().mapRow(sqlResult, sqlResult.row)
				if (potatoTypeEntity == null) throw Exception("Unable to map SQL results to object.")
				potatoTypeEntities.add(potatoTypeEntity)
			}
		}

		return potatoTypeEntities
	}
}

However, whenever this method is called, I see the following message in my IntelliJ console window/log:

WARN  [io.agr.pool] (vert.x-eventloop-thread-0) Datasource 'test': JDBC resources leaked: 1 ResultSet(s) and 1 Statement(s)

Is there something I should be doing differently to perform my database query?

[quarkus-bot[bot]]

/cc @evanchooly

[jehrenzweig-leagueapps]

Of course I figured out the answer immediately after posting the question. But for posterity and/or in case it proves helpful to anyone else, here is what the updated code block -- that no longer produces the warning -- looks like:

this.testDataSource.connection.use { dbConnection ->
	val sqlQuery = "select * from PotatoTypes order by NAME"

	dbConnection.prepareStatement(sqlQuery).use { preparedStatement ->
		preparedStatement.executeQuery().use { resultSet ->
			while (resultSet.next()) {
				val potatoTypeEntity = PotatoTypeEntityJdbcRowMapper().mapRow(resultSet, resultSet.row)
				if (potatoTypeEntity == null) throw Exception("Unable to map SQL results to object.")
				potatoTypeEntities.add(potatoTypeEntity)
			}
		}
	}
}

[evanchooly]

You should only need to use the PreparedStatement since closing that will close any ResultSet.