Problem with Flyway after upgrade to 2.12.0.Final

[luca-bassoricci]

Currently I'm sticky to flyway-core 7.15.0 because most recent versions of Flyway doesn't support our MSSQL version.
After upgrading to Quarkus latest version this error shown up:

2022-09-01 13:19:34,907 WARN  [io.qua.arc.impl] (Quarkus Main Thread) An error occurred during delivery of the @BeforeDestroyed(ApplicationScoped.class) event: javax.enterprise.inject.CreationException: Synthetic bean instance for io.quarkus.scheduler.common.runtime.SchedulerContext not initialized yet: io_quarkus_scheduler_common_runtime_SchedulerContext_97d170e1550eee4afc0af065b78cda302a97674c
	- a synthetic bean initialized during RUNTIME_INIT must not be accessed during STATIC_INIT
	- RUNTIME_INIT build steps that require access to synthetic beans initialized during RUNTIME_INIT should consume the SyntheticBeansRuntimeInitBuildItem
	at io.quarkus.scheduler.common.runtime.SchedulerContext_2480566c4c93757dc0e739a48013b17f9a0be445_Synthetic_Bean.create(Unknown Source)
	at io.quarkus.scheduler.common.runtime.SchedulerContext_2480566c4c93757dc0e739a48013b17f9a0be445_Synthetic_Bean.get(Unknown Source)
	at io.quarkus.scheduler.common.runtime.SchedulerContext_2480566c4c93757dc0e739a48013b17f9a0be445_Synthetic_Bean.get(Unknown Source)
	at io.quarkus.arc.impl.CurrentInjectionPointProvider.get(CurrentInjectionPointProvider.java:60)
	at io.quarkus.quartz.runtime.QuartzScheduler_Bean.create(Unknown Source)
	at io.quarkus.quartz.runtime.QuartzScheduler_Bean.create(Unknown Source)
	at io.quarkus.arc.impl.AbstractSharedContext.createInstanceHandle(AbstractSharedContext.java:111)
	at io.quarkus.arc.impl.AbstractSharedContext$1.get(AbstractSharedContext.java:35)
	at io.quarkus.arc.impl.AbstractSharedContext$1.get(AbstractSharedContext.java:32)
	at io.quarkus.arc.impl.LazyValue.get(LazyValue.java:26)
	at io.quarkus.arc.impl.ComputingCache.computeIfAbsent(ComputingCache.java:69)
	at io.quarkus.arc.impl.AbstractSharedContext.get(AbstractSharedContext.java:32)
	at io.quarkus.quartz.runtime.QuartzScheduler_Observer_destroy_fb1039b288e54ae74a9e1acfa476b03b6c5afceb.notify(Unknown Source)
	at io.quarkus.arc.impl.EventImpl$Notifier.notifyObservers(EventImpl.java:323)
	at io.quarkus.arc.impl.EventImpl$Notifier.notify(EventImpl.java:311)
	at io.quarkus.arc.impl.EventImpl$Notifier.notify(EventImpl.java:241)
	at io.quarkus.arc.impl.ArcContainerImpl.shutdown(ArcContainerImpl.java:394)
	at io.quarkus.arc.Arc.shutdown(Arc.java:57)
	at io.quarkus.arc.runtime.ArcRecorder$1.run(ArcRecorder.java:47)
	at io.quarkus.runtime.StartupContext.runAllInReverseOrder(StartupContext.java:84)
	at io.quarkus.runtime.StartupContext.close(StartupContext.java:73)
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
	at io.quarkus.runtime.Application.start(Application.java:101)
	at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:110)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:67)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:41)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:120)
	at io.quarkus.runner.GeneratedMain.main(Unknown Source)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.runner.bootstrap.StartupActionImpl$1.run(StartupActionImpl.java:103)
	at java.base/java.lang.Thread.run(Thread.java:834)

2022-09-01 13:19:34,912 ERROR [io.qua.run.Application] (Quarkus Main Thread) Failed to start application (with profile dev): org.flywaydb.core.internal.license.FlywayTeamsUpgradeRequiredException: Flyway Teams Edition upgrade required: ignoreMigrationPatterns is not supported by Flyway Community Edition
Try Flyway Teams Edition for free: https://rd.gt/2VzHpkY
	at org.flywaydb.core.api.configuration.ClassicConfiguration.setIgnoreMigrationPatterns(ClassicConfiguration.java:759)
	at org.flywaydb.core.api.configuration.FluentConfiguration.ignoreMigrationPatterns(FluentConfiguration.java:590)
	at io.quarkus.flyway.runtime.FlywayCreator.createFlyway(FlywayCreator.java:79)
	at io.quarkus.flyway.runtime.FlywayContainerProducer.createFlyway(FlywayContainerProducer.java:37)
	at io.quarkus.flyway.runtime.FlywayRecorder.flywaySupplier(FlywayRecorder.java:59)
	at io.quarkus.deployment.steps.FlywayProcessor$createBeansAndStartActions2063183959.deploy_0(Unknown Source)
	at io.quarkus.deployment.steps.FlywayProcessor$createBeansAndStartActions2063183959.deploy(Unknown Source)
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
	at io.quarkus.runtime.Application.start(Application.java:101)
	at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:110)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:67)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:41)
	at io.quarkus.runtime.Quarkus.run(Quarkus.java:120)
	at io.quarkus.runner.GeneratedMain.main(Unknown Source)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at io.quarkus.runner.bootstrap.StartupActionImpl$1.run(StartupActionImpl.java:103)
	at java.base/java.lang.Thread.run(Thread.java:834)

The problem is at FlywayCreator#createFlyway(): this method calls FluentConfiguration#ignoreMigrationPatterns() which is using a premium feature of Flyway.
Which is the right approch to solve the problem?
Should flyway module be aware of Flyway Team version and have a separate management for free and premium settings during configuration creation?

Best regards
Luca

[quarkus-bot[bot]]

/cc @cristhiank, @gastaldi, @geoand, @gsmet

[gastaldi]

Hi @luca-bassoricci,

Do you have quarkus.flyway.ignore-migration-patterns set in your application.properties? The Flyway documentation says that if you use a type different than * you need Flyway teams.

We probably need to revisit this, Quarkus does not support the Flyway premium settings yet.

[gastaldi]

Unfortunately, it won't work. Quarkus core extensions need to be on the same Quarkus version.
Downgrading Flyway won't work either in this case. Do you see any stacktrace if you add the dependency above?

[gastaldi]

I tested with a local SQL Server 2016 and I see that the following error prevents it from working:

2022-09-01 11:34:44,808 ERROR [io.qua.run.Application] (Quarkus Main Thread) Failed to start application (with profile dev): org.flywaydb.core.internal.license.FlywayEditionUpgradeRequiredException: Flyway Teams Edition or SQL Server upgrade required: SQL Server 2016 is no longer supported by Flyway Community Edition, but still supported by Flyway Teams Edition.

I'd refrain from downgrading to an older Flyway version as it won't work with the latest Quarkus versions. In this case, is using Liquibase an option for you?

[luca-bassoricci]

This is exactly the same error we encountered some months ago.
About Liquibase, I have to talk with other people if a change is possible and which effort is required.
I haven't any other ideas, for now.
Thanks for your time, I've truly appreciate your help!

Luca

[gastaldi]

No problem. Glad I could help ;)

[gastaldi]

I tested changing your reproducer project to use quarkus-liquibase instead of quarkus-flyway and added the following properties to application.properties:

quarkus.liquibase.migrate-at-start=true
quarkus.liquibase.change-log=db/changelog.mssql.sql

This is my src/main/resources/db/changelog.mssql.sql file:

--liquibase formatted sql

--changeset nvoxland:1
create table test1 (
                       id int primary key,
                       name varchar(255)
);
--rollback drop table test1;

--changeset nvoxland:2
insert into test1 (id, name) values (1, 'name 1');
insert into test1 (id,  name) values (2, 'name 2');

And it works :)