io.quarkus.platform as default for quarkus.platform.group-id in QuarkusCodestartTest?

[joes]

The pom.xml that is generated by my extension project's integration tests (by way of @RegisterExtension) in integration-tests/target/quarkus-codestart-test/my-extension-c0b1482a-0b6f-4469-9e6a-e0339a2d308e/real-data/java has io.quarkus as quarkus.platform.group-id:

<quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>

Should that not be io.quarkus.platform by default @ia3andy ? This does seem to be the case if a codestart is invoked by the maven mojo io.quarkus.platform:quarkus-maven-plugin:2.13.4.Final:create as well as as quarkus create app so I think it would be nice if the project generated by the integration-tests was aligned with these.

For that to happen QuarkusCodestartTest.quarkusBomGroupId could be adjusted here:

quarkus/independent-projects/tools/devtools-testing/src/main/java/io/quarkus/devtools/testing/codestarts/QuarkusCodestartTest.java

Lines 108 to 110 in 402107d

	if (quarkusBomVersion != null) {
	enableRegistryClientTestConfig(quarkusBomGroupId != null ? quarkusBomGroupId : "io.quarkus", quarkusBomVersion);
	} else {

Do you agree @ia3andy? Should I make this a pull request?

[quarkus-bot[bot]]

/cc @ia3andy, @quarkusio/devtools

[joes]

Sorry, I am still not sure about the CEQ question, are you asking for some specific maven dependency? Could you provide me the maven groupId and artifactId and I shall check for you @aloubyansky.

[aloubyansky]

What do you use from the quarkus-camel-bom? Do you depend on any specific extension managed in the quarkus-camel-bom?

[joes]

I use quite a lot of dependencies from that bom but none of these are extensions @aloubyansky

The codestarter for my extension has a runtime/src/main/codestarts/quarkus/khbro-camel-integration-codestart/base/pom.xml defining the bom:

<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
    <dependencyManagement>
        <dependencies>
            <dependency>
                <groupId>${quarkus.platform.group-id}</groupId>
                <artifactId>quarkus-camel-bom</artifactId>
                <version>${quarkus.platform.version}</version>
                <type>pom</type>
                <scope>import</scope>
            </dependency>
        </dependencies>
    </dependencyManagement>

The codestarter's pom.xml is merged with the generated project as defined by smart-pom-merge in codestart.yml:

#...
output-strategy:
  "pom.xml": smart-pom-merge

And the same codestart.yml brings in these dependencies from the quarkus-camel-bom to the project generated by the codestarter:

language:
  base:
    dependencies:
      - org.apache.camel.quarkus:camel-quarkus-bean
      - org.apache.camel.quarkus:camel-quarkus-bean-validator
      - org.apache.camel.quarkus:camel-quarkus-caffeine
      - org.apache.camel.quarkus:camel-quarkus-core
      - org.apache.camel.quarkus:camel-quarkus-cron
      - org.apache.camel.quarkus:camel-quarkus-csv
      - org.apache.camel.quarkus:camel-quarkus-direct
      - org.apache.camel.quarkus:camel-quarkus-file
      - org.apache.camel.quarkus:camel-quarkus-freemarker
      - org.apache.camel.quarkus:camel-quarkus-ftp
      - org.apache.camel.quarkus:camel-quarkus-headersmap
      - org.apache.camel.quarkus:camel-quarkus-http
      - org.apache.camel.quarkus:camel-quarkus-jackson
      - org.apache.camel.quarkus:camel-quarkus-jslt
      - org.apache.camel.quarkus:camel-quarkus-jsonpath
      - org.apache.camel.quarkus:camel-quarkus-openapi-java
      - org.apache.camel.quarkus:camel-quarkus-quartz
      - org.apache.camel.quarkus:camel-quarkus-rest
      - org.apache.camel.quarkus:camel-quarkus-rest-openapi
      - org.apache.camel.quarkus:camel-quarkus-timer
      - org.apache.camel.quarkus:camel-quarkus-xj
      - org.apache.camel.quarkus:camel-quarkus-xslt-saxon
      - org.apache.camel.quarkus:camel-quarkus-yaml-dsl
      - org.apache.camel.quarkus:camel-quarkus-microprofile-health
      - org.apache.camel.quarkus:camel-quarkus-jta
      - org.apache.camel.quarkus:camel-quarkus-jpa
      - org.apache.camel.quarkus:camel-quarkus-log-deployment

None of these dependencies are other extensions.

[aloubyansky]

Thanks for the details @joes We probably should change it to io.quarkus.platform indeed and override it in the Quarkus core testsuite instead of requiring you to do that.
What you are doing could end up being somewhat fragile, unfortunately (although, there is probably no better way of doing it now). Basically, you are adding the BOM and dependencies w/o knowing what other dependencies the project will include. That could potentially result in conflicts. The Quarkus dev tools aren't helping with that today, unfortunately, but we are planning to enhancing them for these kinds of use-cases.

BTW, off-topic but related, is there a reason you are adding camel-quarkus-log-deployment as a runtime dependency?

[joes]

BTW, off-topic but related, is there a reason you are adding camel-quarkus-log-deployment as a runtime dependency?

No reason - just a mistake by me.

[ia3andy]

@aloubyansky any thought?