quarkus.grpc.server.use-separate-server lead unexpected missing error grpc status

[spencercjh]

When I disable quarkus.grpc.server.use-separate-server and use a common port for http and grpc server, I found that content of io.grpc.Status is missing in the response. I can only receive a UNKNOWN code response whether in my test codes or QuarkusDev.

I can make sure that I correctly invoke responseStreamObserver.onError to return error to clients.

cc @renyijiu

[quarkus-bot[bot]]

/cc @alesj (grpc), @cescoffier (grpc)

[alesj]

Do you have a reproducer? (or a test for this?)

…

On Sat, 14 Jan 2023 at 09:59, quarkus-bot[bot] ***@***.***> wrote: /cc @alesj <https://github.com/alesj> (grpc), @cescoffier <https://github.com/cescoffier> (grpc) — Reply to this email directly, view it on GitHub <#30379 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACRA6AOWRS6MXEMBNYOO2LWSJTHBANCNFSM6AAAAAAT3FHB5M> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[spencercjh]

@alesj I finally found problem. The exception passed to responseObserver#onError is build by io.grpc.protobuf.StatusProto#toStatusRuntimeException can't be processed correctly. When quarkus.grpc.server.use-separate-server is false, everything is OK.

reproducer: https://github.com/spencercjh/reproducer-discussion-30379

[alesj]

Hmmm, this looks like an issue between our new Vert.x gRPC server and plain Netty based Channel.
If I set this

    clients:
      stub:
        use-quarkus-grpc-client: true
        host: localhost
        port: 8081

it works ...

@cescoffier @vietj ^^

[cescoffier]

Yes,

So, if you use use-separate-server: true, make sure your gRPC server does not use the SAME port of the main HTTP server (if enabled). If you don't the requests go to the main HTTP server and the server rejects the requests. Note that I would expect a bind error in this case (need to check that). If the port are different, everything is fine.

If you use use-separate-server:false, then everything works as expected.

[alesj]

My note to my testing -- I was using latest local Quarkus build (999-SNAPSHOT).
Just to make sure new ExceptionHandler feature didn't already fixed this ...

I'll try to port tests over to Quarkus, and test all mix of combos -- new server+old client, old server + new client, ...

[alesj]

Here:

• https://github.com/alesj/quarkus/tree/i30379

3 tests fail ...

[cescoffier]

All fixed!

[spencercjh]

so, it's fixed now? In which release?

[cescoffier]

Yes, it's fixed. The safest it to take the latest one.