Using . as separator in property names (after prefix)

[ppatierno]

Hello,
I know that when using @ConfigMapping we are relying on Smallrye but I am having troubles with naming keys in a Map field.
From the doc here https://quarkus.io/guides/config-mappings#maps I would like to have the names of my properties using . as separator.
Referring to the example on the doc, is it possible to have something like this?

server.form.landing.page=index.html

So I would like to have all stuff coming after server.form (the config prefix), to be used as key in my map, so the key would be landing.page (and not landing-page as in the example).

I am already using smallrye.config.mapping.validate-unknown=false to avoid validation errors, but anyway my Map is empty.

I know it's possible by putting double quotes around but it doesn't work for us because we are porting to quarkus something we already have in place and cannot ask to users to change all their parameters.

[radcortez]

We don't support that at the moment, but I guess that if you have a mapping type of Map<String, String> (or any other Leaf element), we could assume that everything after the mapping path belongs to the key. For nested elements, we cannot do such an assumption, because we don't have a way to know when the key ends and the nested properties elements start.

[ppatierno]

I am using an interceptor for quoting as you suggested ....

public class BridgeConfigSourceInterceptor implements ConfigSourceInterceptor {

    @Override
    public ConfigValue getValue(ConfigSourceInterceptorContext context, String s) {
        ConfigValue cv = context.proceed(s);
        if (s.startsWith(KafkaConsumerConfig.KAFKA_CONSUMER_CONFIG_PREFIX)) {
            return cv.withName(this.withQuotes(KafkaConsumerConfig.KAFKA_CONSUMER_CONFIG_PREFIX, s));
        }
        if (s.startsWith(KafkaProducerConfig.KAFKA_PRODUCER_CONFIG_PREFIX)) {
            return cv.withName(this.withQuotes(KafkaProducerConfig.KAFKA_PRODUCER_CONFIG_PREFIX, s));
        }
        if (s.startsWith(KafkaAdminConfig.KAFKA_ADMIN_CONFIG_PREFIX)) {
            return cv.withName(this.withQuotes(KafkaAdminConfig.KAFKA_ADMIN_CONFIG_PREFIX, s));
        }
        if (s.startsWith(KafkaConfig.KAFKA_CONFIG_PREFIX)) {
            return cv.withName(this.withQuotes(KafkaConfig.KAFKA_CONFIG_PREFIX, s));
        }
        if (s.equals(HttpConfig.HTTP_PORT)) {
            return cv.withName("quarkus.http.port");
        }
        if (s.equals(HttpConfig.HTTP_HOST)) {
            return cv.withName("quarkus.http.host");
        }
        return cv;
    }

    private String withQuotes(String prefix, String key) {
        return String.format("%s\"%s\"", prefix, key.substring(prefix.length()));
    }
}

I am also mapping our http.port to the quarkus.http.port so that the user can still use our parameter instead of the quarkus one to configure the HTTP server.

[ppatierno]

@radcortez sorry I just noticed your comment on the GitHub issue about extending the relocate and fallback interceptors. I will look into them instead of having the one above :-)

[radcortez]

Yes, the quotes rewriting is OK. My recommendation was for the http.port and maybe others, which you could use the relocate or the fallback interceptor directly.

[ppatierno]

@radcortez I just created a relocate interceptor like this:

public class BridgeConfigRelocateInterceptor extends RelocateConfigSourceInterceptor {
    public BridgeConfigRelocateInterceptor(Map<String, String> mappings) {
        // code ....
    }
}

But the application fails with:

(main) Failed to start quarkus: java.util.ServiceConfigurationError: io.smallrye.config.ConfigSourceInterceptor: io.strimzi.kafka.bridge.quarkus.config.BridgeConfigRelocateInterceptor Unable to get public no-arg constructor
        at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:582)
        at java.base/java.util.ServiceLoader.getConstructor(ServiceLoader.java:673)
        at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1233)
        at java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1265)
        at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1300)
        at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1385)
        at io.smallrye.config.SmallRyeConfigBuilder.discoverInterceptors(SmallRyeConfigBuilder.java:134)
        at io.smallrye.config.SmallRyeConfig$ConfigSources.buildInterceptors(SmallRyeConfig.java:599)
        at io.smallrye.config.SmallRyeConfig$ConfigSources.<init>(SmallRyeConfig.java:545)
        at io.smallrye.config.SmallRyeConfig.<init>(SmallRyeConfig.java:68)
        at io.smallrye.config.SmallRyeConfigBuilder.build(SmallRyeConfigBuilder.java:532)
        at io.quarkus.runtime.configuration.QuarkusConfigFactory.getConfigFor(QuarkusConfigFactory.java:36)
        at io.smallrye.config.SmallRyeConfigProviderResolver.getConfig(SmallRyeConfigProviderResolver.java:76)
        at io.quarkus.deployment.QuarkusAugmentor.run(QuarkusAugmentor.java:181)
        at io.quarkus.runner.bootstrap.AugmentActionImpl.runAugment(AugmentActionImpl.java:331)
        at io.quarkus.runner.bootstrap.AugmentActionImpl.createInitialRuntimeApplication(AugmentActionImpl.java:252)
        at io.quarkus.runner.bootstrap.AugmentActionImpl.createInitialRuntimeApplication(AugmentActionImpl.java:60)
        at io.quarkus.deployment.dev.IsolatedDevModeMain.firstStart(IsolatedDevModeMain.java:86)
        at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:447)
        at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:59)
        at io.quarkus.bootstrap.app.CuratedApplication.runInCl(CuratedApplication.java:149)
        at io.quarkus.bootstrap.app.CuratedApplication.runInAugmentClassLoader(CuratedApplication.java:104)
        at io.quarkus.deployment.dev.DevModeMain.start(DevModeMain.java:131)
        at io.quarkus.deployment.dev.DevModeMain.main(DevModeMain.java:62)
Caused by: java.lang.NoSuchMethodException: io.strimzi.kafka.bridge.quarkus.config.BridgeConfigRelocateInterceptor.<init>()
        at java.base/java.lang.Class.getConstructor0(Class.java:3349)
        at java.base/java.lang.Class.getConstructor(Class.java:2151)
        at java.base/java.util.ServiceLoader$1.run(ServiceLoader.java:660)
        at java.base/java.util.ServiceLoader$1.run(ServiceLoader.java:657)
        at java.base/java.security.AccessController.doPrivileged(Native Method)
        at java.base/java.util.ServiceLoader.getConstructor(ServiceLoader.java:668)
        ... 22 more

[radcortez]

You need a public no-args constructor if the interceptor is registered via the ServiceLoader. If you want to bootstrap it yourself, please use ConfigSourceInterceptorFactory. This will give you access to the current Config when building the interceptor. Useful to provide configuration.

[radcortez]

With smallrye/smallrye-config#900, SmallRye Config will support dotted keys without quotes for non-nested Map elements.

[ppatierno]

That's cool! Great work @radcortez !