Reactive Claims injection? keeps throwing blocking errors :(

[NinekoTheCat]

The current thread cannot be blocked: vert.x-eventloop-thread-2

it for some reason isn't reactive? I don't understand

@Path("/hoard/items")
@RequestScoped
public class HoardItems {
  @Inject
  LoginHelper loginHelper;
  @Inject
  @Claim(standard = Claims.sub)
  String openUserId;
  @Inject
  @Claim(standard = Claims.upn)
  String userName;
  @Inject
  HoardItemService hoardItemService;
  @GET
  @Authenticated
  public Uni<List<HoardItemId>> list() {
    return Uni.createFrom().emitter(uniEmitter -> {
      List<HoardItemId> items =  loginHelper.loginUser(userName, openUserId)
          .onItem()
          .transformToUni(hoardItemService::getHoardItemsForUser)
          .await()
          .indefinitely();
      uniEmitter.complete(items);
    });

  }
}

@ApplicationScoped
public class LoginHelper {
  @Inject
  UserService service;
  public Uni<UserId> loginUser(@NonNull String userName, @NonNull String openUserId) {
    return service.login(User
        .builder()
        .id(UserId.builder().openid(openUserId).build())
        .username(userName)
        .build());
  }
}

[quarkus-bot[bot]]

/cc @Ladicek (arc), @manovotn (arc), @mkouba (arc)

[Ladicek]

This has nothing to do with ArC, removing the label.

The HoardItems.list() method directly calls .await().indefinitely(), which is a blocking operation by definition. Also the code is hardly idiomatic; why don't you just do

  public Uni<List<HoardItemId>> list() {
    return loginHelper.loginUser(userName, openUserId)
      .flatMap(hoardItemService::getHoardItemsForUser);
  }

?

[NinekoTheCat]

sadly this does not solve the underlying issue as it's still complaining that it is blocking the thread

[Ladicek]

There's likely some other blocking operation down there, then. All the code shown above seems to refer to your own classes, so can't really help, sorry.

[NinekoTheCat]

it's alright I think I need to refactor the code in my domain classes to not use await().indefinitely()

I am new to reactive programming so I apologise for my weird mistakes

[NinekoTheCat]

  public Uni<UserId> login(@NonNull User user) {
    return Uni.createFrom().emitter(emitter -> {
      if (user.getId().getOpenid() == null || user.getId().getId() != null) {
        emitter.fail(new UserLoginFailureException());
        return;
      }
      val alreadyExistentUser = userRepository.getUserFromOpId(user.getId().getOpenid())
          .await()
          .indefinitely();
      if (alreadyExistentUser != null) {
        emitter.complete(alreadyExistentUser.getId());
        return;
      }
      val id = userRepository.createUser(user).await().indefinitely();
      emitter.complete(id);
    });
  }

I have a hard time trying to port this logic over to reactive java

[NinekoTheCat]

I'd have to port all these checks to a Uni that returns a UserID and my attempts have been fruitless as every time I try getting it to check if both the openid is not null and if the id is null is hard