Replies: 1 comment
-
moving to Q&A |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
following up from #35686 (comment)
in
quarkus/extensions/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/OpenTelemetryDestroyer.java
Lines 17 to 18 in 09cd879
Both calls return a
CompletableResultCode
, which is effectively aCompletableFuture
. Should we use the.join(SECONDS, TimeUnit.SECONDS)
in both calls to ensure the thread completes?In the context of an HTTP server, with very few shutdowns, this should have a minimal effect, but in AWS Lambda calls, where the shutdowns are very frequent, it could possibly make a difference.
also related to #29448
Beta Was this translation helpful? Give feedback.
All reactions