new ExceptionMapper behaviour since version 3.9

[iompo]

I have an application that uses quarkus-rest and quarkus-undertow. Within the app I've defined a custom Exception Mapper:

@Provider
public class CustomExceptionMapper implements ExceptionMapper<Exception> {
    private static final Logger LOGGER = Logger.getLogger(CustomExceptionMapper.class.getName()); 
    
    @Override
    public Response toResponse(Exception exception) {
        LOGGER.log(Level.SEVERE, exception.getMessage(), exception);
        if (exception instanceof MyCustomException) {
            return Response.status(((MyCustomException) exception).getStatus()).entity(exception.getMessage()).build();
        }

        return Response.status(Response.Status.INTERNAL_SERVER_ERROR).entity("Something went wrong").build();
  }
}

After the update I can't access any of the static resources defined in the app (it is working fine with version 3.8.3). If I define it just for MyCustomException (e.g. ExceptionMapper<MyCustomException>) then everything works fine again. Is that intended? How can I replicate the current behavior I have?

Marco.

[gsmet]

/cc @geoand

[geoand]

I think it broke from 5219229 - cc @phillip-kruger

[phillip-kruger]

Yes that would be my changes that broke this. @iompo do you have a small reproducer I can look at?

[iompo]

@phillip-kruger reproducer available here, there's a failing test that runs fine if CustomExceptionMapper implements ExceptionMapper<MyCustomException> instead of ExceptionMapper<Exception>

[phillip-kruger]

Thanks. Looking now.

[phillip-kruger]

This will fix it. #39897