Quarkus - Panache - Entity updates are not getting persisted

[gmuvvala-bss]

We are using Quarkus Panache with AWS Aurora mysql in our application. We have simple db update as follows

Loan loan = Loan.findById(loanId.getValue());
loan.loanStatusTypeId = 100000;
loan.persist();

We found that some times this change is not getting persisted after transaction is committed . There is no error or transaction rollback. Updates to other entities made as part of the same transaction gets persisted successfully .

Few other points

1. This table has huge no of columns (85).
2. Issue gets resolved once server gets rebooted.
3. Issue happens for every request once system runs in to this state.

Appreciate any help on this.

[quarkus-bot[bot]]

/cc @FroMage (panache), @loicmathieu (panache)

[FroMage]

Does this ring any bell @yrodiere @Sanne ? This sounds more like an ORM issue to me.

@gmuvvala-bss any chance you can create a reproducer for this?

[Sanne]

@gmuvvala-bss , hi! Let's check the basics first.

1. Are you sure the value of field loanStatusTypeId wasn't already set to 100000 ? In this case Hibernate ORM will spot that the update isn't necessary.
2. Why is there an invocation to persist() ? If the entity was just loaded, it's being managed and this shouldn't be necessary. Either you should remove the invocation to persist, or there's more complexity that we need to know about.

[gmuvvala-bss]

@FroMage
I faced this issue in our dev environment only . So I am not sure I can create reproducer for this. But , I will try.

@Sanne
I am sure that loanStatusTypeId was not already set. It's being set to 100000 as part of transaction. persist() method is called to update loan status value in to DB.

Following are the set of actions in transaction

1. load the entity Loan from DB.
2. Update the status from null to 100000
   3). Add entry to status_log table with old_status = null and new_status = 100000
3. save updates to loan entity

After transaction is committed,
loan.loanStatusTypeId still have null
entry created in status_log table with old_status = null and new_status = 100000

I just realized that persist() is not required if the entity is loaded from session. But, calling persist() on already existing object should not have any impact since this call gets ignored.

[Sanne]

I just realized that persist() is not required if the entity is loaded from session.

Right, that's what I was pointing out. It's important to understand how managed entities work, as often problems are caused by users not having the right mental model of how this all works.

After transaction is committed, loan.loanStatusTypeId still have null

I understand but we'll need many more details. Please provide a reproducer.

[bechhansen]

I have seen the same issue.

We have a set of unit test where we updates a ENUM field as described here. About 10% of times the tests fails because the field value is not persisted correct.

I have added getter/setters to the entity, and made the field private. That fixed the issue. Test are now always green.

We are using Postgres. The table has a handful columns and only a few records.
Quarkus version is 3.21.1.

[yrodiere]

This looks a lot like #42479, which was a real pain to debug over many months, because it's semi-random (happens only when concurrent build threads execute in a certain order). It turned out to be caused by optimizations in Hibernate ORM's bytecode enhancement.

I was surprised we didn't get feedback about it, but it seems we did -- in this discussion. Sorry I missed it, but if it's any consolation, I doubt my noticing this discussion would have changed anything: the main (huge) problem was to reproduce the bug reliably.

Anyway, it's been fixed in Hibernate ORM 6.6.12, which will be used by Quarkus 3.22, and we'll likely backport the upgrade to Quarkus 3.15 and 3.20 too.

[gmuvvala-bss]

@yrodiere , Thank you for your response. We haven't seen this issue for a while. And also we don't have any reproducer. So , I can't confirm this got fixed.
Anyway we are planning to upgrade Quarkus to latest LTS version 3.20. Hope #42479 will be backported to 3.20 soon.