Q 3.17.0 becomes sensitive to package name "quarkus" parsing config

[Karm]

Hello,

Beginning Q 3.17.0, i.e. 3.16.4 does not manifest this, I can see this warning in my logs:

[io.qua.config] (main) Unrecognized configuration key "quarkus.hahaha.Service/mp-rest/url" was provided; 
it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo

The app keeps working as it should, it's just that warning that pops up.

The only difference but for "haha" in URL between these two services is their package name. I literally copy pasted the files.

https://github.com/Karm/dev-null/tree/main/rest-client-kjah76/src/main/java/org/acme

https://github.com/Karm/dev-null/tree/main/rest-client-kjah76/src/main/java/quarkus/hahaha

Tests pass for both:

 mvn clean package -Dquarkus.platform.version=3.21.1

So it seems that the configuration parsing, processing application.properties gets confused on "quarkus.hahaha.Service"

quarkus.http.port=8080
%test.quarkus.http.port=8081
quarkus.rest-client."org.acme.Service".url=http://localhost:${quarkus.http.port}/client/service
quarkus.rest-client."quarkus.hahaha.Service".url=http://localhost:${quarkus.http.port}/haha/client/service

QUESTION: Is this expected? Is "quarkus" effectively a reserved word for package naming beginning Quarkus 3.17.0?

[quarkus-bot[bot]]

/cc @radcortez (config)

[dmlloyd]

This almost certainly seems like a bug to me. We don't even use the quarkus.xxx package as far as I know. I think maybe some validation code got cross-wired.

[gsmet]

I think it's due to the Quarkus property being rewritten to quarkus.hahaha.Service/mp-rest/url for MicroProfile REST Client. And then you end up with a property starting with quarkus. so we consider it as a config that should be mapped to an extension.

[radcortez]

Great catch. I think we added some code to deal with these cases, but I'm not sure if that works with this weird case of the REST Client.

[radcortez]

Did you try using a more recent Quarkus version? With had some issues with unknown reporting due to the changes we did to the new config mechanism.

[Karm]

I bisected this

versions=(
"3.16.4"
"3.17.0"
"3.17.0.CR1"
"3.17.1"
"3.17.2"
"3.17.3"
"3.17.4"
"3.17.5"
"3.17.6"
"3.17.7"
"3.18.0"
"3.18.0.CR1"
"3.18.1"
"3.18.2"
"3.18.3"
"3.19.0"
"3.19.0.CR1"
"3.19.1"
"3.19.2"
"3.19.3"
"3.20.0"
"3.20.0.CR1"
)

The message pops up at 3.17.0 for the first time and keeps appearing; the latest included.

[radcortez]

Ok, so probably the @gsmet guess is right. I'll have a look.

[radcortez]

So, in this case, with #42106 we now generate and include in the property names all combinations of names that can be used to set REST Client configuration. Previously, the config was checked on demand, and names were being created on the fly, which caused issues such as #42100.

Indeed, the way that the MP REST client defines how to set configuration as FQN/mp-rest, in combination with our eager and relocation mechanism, causes the warning, since a name like quarkus.rest-client."quarkus.hahaha.Service".url gets rewritten to quarkus.hahaha.Service/mp-rest/url.

We don't really have an easy way to deal with this case. We could add a mechanism to ignore a listed set of names, but I'm not sure if it is worth the trouble, since this also seems to be an edge case.

If this becomes a noticeable issue, we can revisit it.