TokenHelper seems to be a singleton, but in fact it is tied to the client

[smil2k]

Hi,

I'm not certain whether TokenHelper is part of the public api, but it seems that everybody started using it for all sort of things outside quarkus.

The helper was a bit confusing, because it does not hold a reference to the oidcClient (it is always passed to all of the method calls). This makes you think that this is basically a singleton and can be used for more than one client.

Why token helper does not hold a reference?

Cheers,

Tamas

[sberyozkin]

Hi @smil2k, TokenHelper is about facilitating a thread safe use of the OidcClient, and deal with the token refresh when the token expires.

Typically, when the OIDC client filter is used, it is an internal detail.

When OidcClient is accessed directly, TokenHelper makes it easy to for the client code to deal with the thread safety and the token refresh.

But users do not have to use it, and can manually check the token expiry and request a token refresh.

It is true it is not meant to be shared between multiple OIDC clients. I think we can update the docs to make it clear.