-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Description
Description
Hello,
I wanted to suggest some improvements of the documentation about QuarkusTest*Callback
- It does not mention that there is also
QuarkusTestAfterAllCallback - There is
QuarkusTestBeforeClassCallbackbut noQuarkusTestAfterClassCallback? And then there isQuarkusTestAfterAllCallbackbut noQuarkusTestBeforeAllCallback. Or maybe that was on purpose and theQuarkusTestBeforeClassCallbackandQuarkusTestAfterAllCallbackand equivalent of JUnit@BeforeAlland@AfterAll? if so then why one event is calledClassand otherAll? (In old JUnit there was@BeforeClassso maybe thats why, but in jupiter it was removed). I think it would be best to keep the naming the same and to not useClassjust to not make it confusing when compared to JUnit equivalents. - If what I wrote above is wrong and
QuarkusTestBeforeClassCallbackandQuarkusTestAfterAllCallbackare not similar events then what exactly isQuarkusTestAfterAllCallback? After all of what? all methods in test? all tests? This leads me to another suggestion because there are also other callbacks such asQuarkusTestBeforeTestExecutionCallback. What isTestExecutionin this case? Is this happening before/after each@Test, each@QuarkusTestor maybe all of the tests? This is not clear in documentation.
As you can see my point is that it would be great if there would be more description of what kind of events are all of those exactly, when are they triggered and what is their triggering order when compared to each other (for ex. I suppose BeforeClass would happen before BeforeEach etc. but does BeforeClass trigger before AfterConstruct?).
And my last suggestion would be to mention what is actually the difference between using QuarkusTest*Callback and the JUnit own Callback interfaces. Because I could think that they serve exactly the same purpose but in the end JUnit callbacks take less effort (no need to register in service provider) but maybe there is a difference?
Implementation ideas
No response